[ICE-2828] Strip redundant copyright notices in Javascript build - ICEsoft JIRA Issue Tracker

Details

Type: New Feature
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.7Beta1
Fix Version/s: 1.7RC1, 1.7
Component/s: Bridge
Labels:
None
Environment:
All

Description

If you look at the served icefaces-d2d.js and ice-extras.js files, you will see that they hold 24 and 19 redundant copies of our copyright notices, each of which is 1,618 bytes, for a total of 69,574 bytes. We should change the build process, which amalgamates the many Javascript files together, to only include one copy of our copyright notice, and strip out the others.

And how come we're not smallifying these files, or at least stripping out redundant whitespace?

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

build.xml

31/Mar/08 5:06 AM

12 kB

Krashan Brahmanjara
build.xml

31/Mar/08 5:06 AM

22 kB

Krashan Brahmanjara
Hide
compressor.jar

31/Mar/08 5:05 AM

699 kB

Krashan Brahmanjara
META-INF/MANIFEST.MF 0.2 kB

org/mozilla/classfile/ByteCode.class 7 kB

org/mozilla/.../ClassFileField.class 1 kB

org/mozilla/.../ClassFileMethod.class 1 kB

org/mozilla/.../ClassFileWriter.class 25 kB

org/mozilla/classfile/ConstantPool.class 7 kB

org/mozilla/.../ExceptionTableEntry.class 0.6 kB

org/mozilla/.../FieldOrMethodRef.class 1.0 kB

org/mozilla/javascript/Arguments.class 6 kB

org/mozilla/.../BaseFunction.class 12 kB

org/mozilla/.../BeanProperty.class 0.6 kB

org/mozilla/javascript/Callable.class 0.3 kB

org/mozilla/javascript/ClassCache.class 3 kB

org/.../ClassDefinitionException.class 0.5 kB

org/mozilla/.../ClassShutter.class 0.2 kB

org/mozilla/.../CompilerEnvirons.class 3 kB

org/mozilla/javascript/Context.class 36 kB

org/mozilla/.../ContextAction.class 0.2 kB

org/.../ContextFactory$Listener.class 0.3 kB

org/mozilla/.../ContextFactory.class 6 kB

org/mozilla/.../ContextListener.class 0.4 kB

org/mozilla/javascript/DToA.class 13 kB

org/mozilla/javascript/Decompiler.class 14 kB

org/mozilla/.../DefaultErrorReporter.class 2 kB

org/mozilla/.../DefiningClassLoader.class 1 kB

org/mozilla/javascript/Delegator.class 4 kB

org/mozilla/javascript/EcmaError.class 2 kB

org/mozilla/.../ErrorReporter.class 0.3 kB

org/mozilla/.../EvaluatorException.class 1 kB

org/mozilla/.../FieldAndMethods.class 2 kB

Showing 30 of 257 items Download Zip
Show

compressor.jar

31/Mar/08 5:05 AM

699 kB

Krashan Brahmanjara

Issue Links

blocks

ICE-2883 Extremal size of ice-extras.js and icefaces-d2d.js files!

Closed

Activity

Ascending order - Click to sort in descending order

Mark Collette created issue - 05/Mar/08 4:45 PM

Mark Collette made changes - 05/Mar/08 4:48 PM

Field	Original Value	New Value
Description	If you look at the served icefaces-d2d.js and ice-extras.js files, you will see that they hold 24 and 19 redundant copies of our copyright notices, each of which is 1,618 bytes, for a total of 69,574 bytes. We should change the build process, which amalgamates the many Javascript files together, to only include one copy of our copyright notice, and strip out the others.	If you look at the served icefaces-d2d.js and ice-extras.js files, you will see that they hold 24 and 19 redundant copies of our copyright notices, each of which is 1,618 bytes, for a total of 69,574 bytes. We should change the build process, which amalgamates the many Javascript files together, to only include one copy of our copyright notice, and strip out the others. And how come we're not smallifying these files, or at least stripping out redundant whitespace?

Hide

Permalink

Ken Fyten added a comment - 06/Mar/08 7:46 PM

Any suggestions on how to best achieve this?

Show

Ken Fyten added a comment - 06/Mar/08 7:46 PM Any suggestions on how to best achieve this?

Ken Fyten made changes - 06/Mar/08 7:46 PM

Fix Version/s		1.7 [ 10080 ]
Assignee Priority		P2
Assignee		Mircea Toma [ mircea.toma ]

Hide

Permalink

Mircea Toma added a comment - 12/Mar/08 5:39 PM

Yes, we need to switch to YUI Compressor ( http://developer.yahoo.com/yui/compressor/ ).

Show

Mircea Toma added a comment - 12/Mar/08 5:39 PM Yes, we need to switch to YUI Compressor ( http://developer.yahoo.com/yui/compressor/ ).

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#16024	Thu Mar 13 16:59:05 MDT 2008	mircea.toma	Replace Dojo compressor with YUI compressor (version 2.3.5). Refactor build file. ~~ICE-2828~~
				Files Changed
				MODIFY /icefaces/trunk/icefaces/bridge/compressor.jar MODIFY /icefaces/trunk/icefaces/bridge/build.xml

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#16025	Thu Mar 13 17:17:46 MDT 2008	mircea.toma	Replace Dojo compressor with YUI compressor (version 2.3.5). Refactor build file. ~~ICE-2828~~
				Files Changed
				MODIFY /icefaces/trunk/icefaces/core/build.xml

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#16026	Thu Mar 13 17:36:02 MDT 2008	mircea.toma	Fix target. ~~ICE-2828~~
				Files Changed
				MODIFY /icefaces/trunk/icefaces/bridge/build.xml

Hide

Permalink

Mircea Toma added a comment - 13/Mar/08 6:16 PM

Replace Dojo compressor with YUI compressor (version 2.3.5).
Refactor build file.

icefaces-d2d.js – before=84Kb; after=76Kb
ice-extras.js – before=248Kb; after=200Kb

Show

Mircea Toma added a comment - 13/Mar/08 6:16 PM Replace Dojo compressor with YUI compressor (version 2.3.5). Refactor build file. icefaces-d2d.js – before=84Kb; after=76Kb ice-extras.js – before=248Kb; after=200Kb

Mircea Toma made changes - 13/Mar/08 6:16 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#16030	Fri Mar 14 10:41:12 MDT 2008	mircea.toma	Stop caching the DOM element wrappers. ~~ICE-2828~~
				Files Changed
				MODIFY /icefaces/trunk/icefaces/bridge/lib/element.js

Ken Fyten made changes - 19/Mar/08 4:42 PM

Fix Version/s		1.7RC1 [ 10123 ]
Fix Version/s	1.7 [ 10080 ]

Ken Fyten made changes - 26/Mar/08 12:23 PM

Link

This issue blocks ~~ICE-2883~~ [ ~~ICE-2883~~ ]

Hide

Permalink

Krashan Brahmanjara added a comment - 31/Mar/08 5:04 AM

The problem started somewhere after revision 15853.

At this moment good solution is

change current /src/bridge/build.xml to /src/bridge/build.xml from revision 15583
change current /src/bridge/compressor.jar to /src/bridge/compressor.jar from revision 15583
change current /src/core/build.xml to /src/core/build.xml from revision 15583

After this scripts got correct size

src\bridge\build\ice-extras.js has 252 943 bytes
src\bridge\build\icefaces-d2d.js has 84785 bytes

Show

Krashan Brahmanjara added a comment - 31/Mar/08 5:04 AM The problem started somewhere after revision 15853. At this moment good solution is change current /src/bridge/build.xml to /src/bridge/build.xml from revision 15583 change current /src/bridge/compressor.jar to /src/bridge/compressor.jar from revision 15583 change current /src/core/build.xml to /src/core/build.xml from revision 15583 After this scripts got correct size src\bridge\build\ice-extras.js has 252 943 bytes src\bridge\build\icefaces-d2d.js has 84785 bytes

Hide

Permalink

Krashan Brahmanjara added a comment - 31/Mar/08 5:05 AM

Compressor from revision 15853

Show

Krashan Brahmanjara added a comment - 31/Mar/08 5:05 AM Compressor from revision 15853

Krashan Brahmanjara made changes - 31/Mar/08 5:05 AM

Attachment

compressor.jar [ 10893 ]

Hide

Permalink

Krashan Brahmanjara added a comment - 31/Mar/08 5:06 AM

Bridge build from revision 15853

Show

Krashan Brahmanjara added a comment - 31/Mar/08 5:06 AM Bridge build from revision 15853

Krashan Brahmanjara made changes - 31/Mar/08 5:06 AM

Attachment

build.xml [ 10894 ]

Hide

Permalink

Krashan Brahmanjara added a comment - 31/Mar/08 5:06 AM

Core build from revision 15853

Show

Krashan Brahmanjara added a comment - 31/Mar/08 5:06 AM Core build from revision 15853

Krashan Brahmanjara made changes - 31/Mar/08 5:06 AM

Attachment

build.xml [ 10895 ]

Hide

Permalink

Krashan Brahmanjara added a comment - 31/Mar/08 5:19 AM

In comment above I suggest to cancel changes in build.xml files from revisions 16024,16025,16026,16060.

These changes was not necessery.and finally results was 3MB javascripts.

Show

Krashan Brahmanjara added a comment - 31/Mar/08 5:19 AM In comment above I suggest to cancel changes in build.xml files from revisions 16024,16025,16026,16060. These changes was not necessery.and finally results was 3MB javascripts.

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#16294	Fri Apr 04 17:28:02 MDT 2008	mircea.toma	Erase coalesced files before re-creating them. ~~ICE-2828~~
				Files Changed
				MODIFY /icefaces/trunk/icefaces/bridge/build.xml

Ken Fyten made changes - 14/Apr/08 3:37 PM

Fix Version/s

1.7 [ 10080 ]

Ken Fyten made changes - 14/Apr/08 3:38 PM

Status	Resolved [ 5 ]	Closed [ 6 ]
Assignee Priority	P2
Assignee	Mircea Toma [ mircea.toma ]

People

Assignee:

Unassigned

Reporter:

Mark Collette

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

05/Mar/08 4:45 PM

Updated:

14/Apr/08 3:38 PM

Resolved:

13/Mar/08 6:16 PM