ICEfaces
  1. ICEfaces
  2. ICE-2828

Strip redundant copyright notices in Javascript build

          Details

          • Type: New Feature New Feature
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7Beta1
          • Fix Version/s: 1.7RC1, 1.7
          • Component/s: Bridge
          • Labels:
            None
          • Environment:
            All

            Description

            If you look at the served icefaces-d2d.js and ice-extras.js files, you will see that they hold 24 and 19 redundant copies of our copyright notices, each of which is 1,618 bytes, for a total of 69,574 bytes. We should change the build process, which amalgamates the many Javascript files together, to only include one copy of our copyright notice, and strip out the others.

            And how come we're not smallifying these files, or at least stripping out redundant whitespace?
            1. XML File
              build.xml
              12 kB
              Krashan Brahmanjara
            2. XML File
              build.xml
              22 kB
              Krashan Brahmanjara

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-2883 Extremal size of ice-extras.js and icefaces-d2d.js files!

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Ken Fyten added a comment -

                Any suggestions on how to best achieve this?

                Show
                Ken Fyten added a comment - Any suggestions on how to best achieve this?
                Hide
                Permalink
                Mircea Toma added a comment -

                Yes, we need to switch to YUI Compressor ( http://developer.yahoo.com/yui/compressor/ ).

                Show
                Mircea Toma added a comment - Yes, we need to switch to YUI Compressor ( http://developer.yahoo.com/yui/compressor/ ).
                Hide
                Permalink
                Mircea Toma added a comment -

                Replace Dojo compressor with YUI compressor (version 2.3.5).
                Refactor build file.

                icefaces-d2d.js – before=84Kb; after=76Kb
                ice-extras.js – before=248Kb; after=200Kb

                Show
                Mircea Toma added a comment - Replace Dojo compressor with YUI compressor (version 2.3.5). Refactor build file. icefaces-d2d.js – before=84Kb; after=76Kb ice-extras.js – before=248Kb; after=200Kb
                Hide
                Permalink
                Krashan Brahmanjara added a comment -

                The problem started somewhere after revision 15853.

                At this moment good solution is

                • change current /src/bridge/build.xml to /src/bridge/build.xml from revision 15583
                • change current /src/bridge/compressor.jar to /src/bridge/compressor.jar from revision 15583
                • change current /src/core/build.xml to /src/core/build.xml from revision 15583

                After this scripts got correct size

                • src\bridge\build\ice-extras.js has 252 943 bytes
                • src\bridge\build\icefaces-d2d.js has 84785 bytes
                Show
                Krashan Brahmanjara added a comment - The problem started somewhere after revision 15853. At this moment good solution is change current /src/bridge/build.xml to /src/bridge/build.xml from revision 15583 change current /src/bridge/compressor.jar to /src/bridge/compressor.jar from revision 15583 change current /src/core/build.xml to /src/core/build.xml from revision 15583 After this scripts got correct size src\bridge\build\ice-extras.js has 252 943 bytes src\bridge\build\icefaces-d2d.js has 84785 bytes
                Hide
                Permalink
                Krashan Brahmanjara added a comment -

                Compressor from revision 15853

                Show
                Krashan Brahmanjara added a comment - Compressor from revision 15853
                Hide
                Permalink
                Krashan Brahmanjara added a comment -

                Bridge build from revision 15853

                Show
                Krashan Brahmanjara added a comment - Bridge build from revision 15853
                Hide
                Permalink
                Krashan Brahmanjara added a comment -

                Core build from revision 15853

                Show
                Krashan Brahmanjara added a comment - Core build from revision 15853
                Hide
                Permalink
                Krashan Brahmanjara added a comment -

                In comment above I suggest to cancel changes in build.xml files from revisions 16024,16025,16026,16060.

                These changes was not necessery.and finally results was 3MB javascripts.

                Show
                Krashan Brahmanjara added a comment - In comment above I suggest to cancel changes in build.xml files from revisions 16024,16025,16026,16060. These changes was not necessery.and finally results was 3MB javascripts.

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Mark Collette
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: