ICEpdf
  1. ICEpdf
  2. PDF-135

command button Tab focus managment issue

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0 - Beta
    • Fix Version/s: 4.0
    • Component/s: Core/Parsing
    • Labels:
      None
    • Environment:
      RI viewer

      Description

      The RI viewer seems to eat focus in a few different places. Mainly the page number input field and utility pan tabset eat the focus commands tab and tab+shift.

        Activity

        Hide
        Patrick Corless added a comment -

        When tabbing out of the page inputTextField the page view would grab focus and all subsequent tabs would happen inside of the document view, which means going to the next page if the column views where used. This tabbing resulted in the currentpage index going up, when in fact the page has focus but wasn't viewable in the view port.

        The second problem is related to the JSplitPane component we use in the RI to seperate the utility panel and page view panel. The split paint under the BasicLookAndFeel is assinged a keyboard mapping of "F6" to toggle focus between pains. This is what is causing the "F6" and but not the "shift F6" from working correctly or panel assignment.

        The page component changes is pretty easy fix as we currently don't have a focus manager for the annotation components and thus can remove the setFocusable call from the PageViewComponentImpl component for the time being.

        The splitpane used in ri is an instance variable of SwingController and can manually have the 'F6' removed from its action map.

        Show
        Patrick Corless added a comment - When tabbing out of the page inputTextField the page view would grab focus and all subsequent tabs would happen inside of the document view, which means going to the next page if the column views where used. This tabbing resulted in the currentpage index going up, when in fact the page has focus but wasn't viewable in the view port. The second problem is related to the JSplitPane component we use in the RI to seperate the utility panel and page view panel. The split paint under the BasicLookAndFeel is assinged a keyboard mapping of "F6" to toggle focus between pains. This is what is causing the "F6" and but not the "shift F6" from working correctly or panel assignment. The page component changes is pretty easy fix as we currently don't have a focus manager for the annotation components and thus can remove the setFocusable call from the PageViewComponentImpl component for the time being. The splitpane used in ri is an instance variable of SwingController and can manually have the 'F6' removed from its action map.
        Hide
        Patrick Corless added a comment -

        I had to removed the focusable from the page and annotation components. In a column view with 50 pages as soon as the first page was given focus the next focus item was the next page. This made it very hard to get back up to the main controls. I'll revisit the focus management issue for column views in a future release.

        The main viewer RI split pane key map action for F6 has been disabled for the "ToggleFocus" key.

        Closing issue, focus is no longer lost or stolen by the viewer RI.

        Show
        Patrick Corless added a comment - I had to removed the focusable from the page and annotation components. In a column view with 50 pages as soon as the first page was given focus the next focus item was the next page. This made it very hard to get back up to the main controls. I'll revisit the focus management issue for column views in a future release. The main viewer RI split pane key map action for F6 has been disabled for the "ToggleFocus" key. Closing issue, focus is no longer lost or stolen by the viewer RI.
        Hide
        Patrick Corless added a comment -

        The client is reporting that ctr-tab is not working when the search pane is open. Revisiting issue.

        Show
        Patrick Corless added a comment - The client is reporting that ctr-tab is not working when the search pane is open. Revisiting issue.
        Hide
        Patrick Corless added a comment -

        After further investigation it turns out that the default behaviour for windows tab focus selection is down with ctr and ctrl-shift tab. The definition is defined in the WindowsLookAndFeel class. We could over change the focus key for tabs but it would break a very expected behaviour I recommend the client makes the change them self or reconsider if this is really a problem for them.

        Show
        Patrick Corless added a comment - After further investigation it turns out that the default behaviour for windows tab focus selection is down with ctr and ctrl-shift tab. The definition is defined in the WindowsLookAndFeel class. We could over change the focus key for tabs but it would break a very expected behaviour I recommend the client makes the change them self or reconsider if this is really a problem for them.

          People

          • Assignee:
            Patrick Corless
            Reporter:
            Patrick Corless
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: