ICEpdf
  1. ICEpdf
  2. PDF-133

Text Selection/highlight optimizations

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0 - Beta
          • Fix Version/s: 4.0
          • Component/s: Core/Parsing
          • Labels:
            None
          • Environment:
            any

            Description

            Update the Text data structure to remove Geometric path instances. It appears that the path information is no longer needed and as a result bounds can be used for painting. A refactor is needed to convert the mouse or selection rectangle to page space and then apply paint and selection logic. This will greatly reduce the number of object created to support text extraction.

              Activity

              Hide
              Permalink
              Patrick Corless added a comment -

              Thanks to Mark to do a peer review of the text selection code and noticing the large number of Geometric paths that where created for each page.

              I reviewed the text selection code and found two areas that could be improved. The first was to convert the mouse point or selection rectangle to page space before doing containment and intersection tests. Once the mouse coords where in the correct space there was no need to keep the geometric path around in the text object, the pre calculated bounds where all that where needed to calculate selected text.

              Checked in code, marking as fixed.

              Show
              Patrick Corless added a comment - Thanks to Mark to do a peer review of the text selection code and noticing the large number of Geometric paths that where created for each page. I reviewed the text selection code and found two areas that could be improved. The first was to convert the mouse point or selection rectangle to page space before doing containment and intersection tests. Once the mouse coords where in the correct space there was no need to keep the geometric path around in the text object, the pre calculated bounds where all that where needed to calculate selected text. Checked in code, marking as fixed.

                People

                • Assignee:
                  Patrick Corless
                  Reporter:
                  Patrick Corless
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: