ICEfaces
  1. ICEfaces
  2. ICE-7568

JavaScript error thrown when trying to add new tabs after filtering a dataTable

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.RC1
    • Fix Version/s: 3.0.RC2, 3.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 3.0 RC1, Williams App and POC, FireFox browser
    • Assignee Priority:
      P1

      Description

      Steps to reproduce issue in Williams POC:
       - SVN update POC to make sure you have latest code and use the ICEfaces 3.0 RC release.
       - Load POC
       - Load the first tab with Screen 1.
       - Click retrieve button.
       - Click on the '+' Menu item to load a new blank tab.
       - Go back to the first tab.
       - Enter in '2' for the ID column filter input.
       - Clear out the input.
       - Click on the '+' Menu item to try and load a new tab. -> Nothing happens.
       - Click on the '+' Menu item again, a JavaScript error is thrown, two tabs are now loaded at once.

        Activity

        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Ken Fyten made changes -
        Security Private [ 10001 ]
        Ken Fyten made changes -
        Fix Version/s 3.0.RC2 [ 10313 ]
        Ken Fyten made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Nils Lundquist made changes -
        Assignee Mark Collette [ mark.collette ] Ted Goddard [ ted.goddard ]
        Hide
        Nils Lundquist added a comment -

        Found that the issue is related to interaction between missing subtree handling and tabset caching behaviour.

        Assigning to Ted to adjust missing subtree handling.

        Show
        Nils Lundquist added a comment - Found that the issue is related to interaction between missing subtree handling and tabset caching behaviour. Assigning to Ted to adjust missing subtree handling.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #26851 Tue Dec 13 11:08:19 MST 2011 ted.goddard when subtree DOM rendering cannot target the oldDOM, return the component output as a ReplaceOperation anyway (ICE-7568)
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMPartialViewContext.java
        Hide
        Nils Lundquist added a comment -

        Dec 13, 2011 9:36:50 AM org.icefaces.impl.context.DOMPartialRenderCallback visit
        WARNING: Subtree rendering for sub_Screen1:screen1Form:masterTable could not be found and is being ignored.
        Dec 13, 2011 9:36:51 AM org.icefaces.impl.context.DOMPartialRenderCallback visit
        WARNING: Subtree rendering for sub_Screen1:screen1Form:masterTable could not be found and is being ignored.

        Is the only output at post-tab filtering when the table config panel is removed.

        Show
        Nils Lundquist added a comment - Dec 13, 2011 9:36:50 AM org.icefaces.impl.context.DOMPartialRenderCallback visit WARNING: Subtree rendering for sub_Screen1:screen1Form:masterTable could not be found and is being ignored. Dec 13, 2011 9:36:51 AM org.icefaces.impl.context.DOMPartialRenderCallback visit WARNING: Subtree rendering for sub_Screen1:screen1Form:masterTable could not be found and is being ignored. Is the only output at post-tab filtering when the table config panel is removed.
        Hide
        Nils Lundquist added a comment -

        The output above disappears when the <ace:ajax event="select" /> tag is removed from the table. "sub_Screen1:screen1Form:dtlDvdr" is the target of the ace:ajax execute/render.

        The following output occurs post filter:
        Dec 13, 2011 9:29:49 AM org.icefaces.impl.context.DOMPartialRenderCallback visit
        WARNING: Subtree rendering for sub_Screen1:screen1Form:j_idt31 could not be found and is being ignored.
        Dec 13, 2011 9:29:49 AM org.icefaces.impl.context.DOMPartialRenderCallback visit
        WARNING: Subtree rendering for sub_Screen1:screen1Form:masterTable could not be found and is being ignored.
        Dec 13, 2011 9:29:50 AM org.icefaces.impl.context.DOMPartialRenderCallback visit
        WARNING: Subtree rendering for sub_Screen1:screen1Form:j_idt31 could not be found and is being ignored.
        Dec 13, 2011 9:29:50 AM org.icefaces.impl.context.DOMPartialRenderCallback visit
        WARNING: Subtree rendering for sub_Screen1:screen1Form:masterTable could not be found and is being ignored.

        sub_Screen1:screen1Form:j_idt31 is the ID of the table config panel. ... I think that'll be our culprit.

        Show
        Nils Lundquist added a comment - The output above disappears when the <ace:ajax event="select" /> tag is removed from the table. "sub_Screen1:screen1Form:dtlDvdr" is the target of the ace:ajax execute/render. The following output occurs post filter: Dec 13, 2011 9:29:49 AM org.icefaces.impl.context.DOMPartialRenderCallback visit WARNING: Subtree rendering for sub_Screen1:screen1Form:j_idt31 could not be found and is being ignored. Dec 13, 2011 9:29:49 AM org.icefaces.impl.context.DOMPartialRenderCallback visit WARNING: Subtree rendering for sub_Screen1:screen1Form:masterTable could not be found and is being ignored. Dec 13, 2011 9:29:50 AM org.icefaces.impl.context.DOMPartialRenderCallback visit WARNING: Subtree rendering for sub_Screen1:screen1Form:j_idt31 could not be found and is being ignored. Dec 13, 2011 9:29:50 AM org.icefaces.impl.context.DOMPartialRenderCallback visit WARNING: Subtree rendering for sub_Screen1:screen1Form:masterTable could not be found and is being ignored. sub_Screen1:screen1Form:j_idt31 is the ID of the table config panel. ... I think that'll be our culprit.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #26840 Mon Dec 12 16:58:47 MST 2011 ted.goddard discard render requests for nonexistent subtrees (ICE-7568)
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMPartialViewContext.java
        Hide
        Ted Goddard added a comment -

        Dec 12, 2011 3:40:13 PM org.icefaces.ace.util.ComponentUtils findClientIds
        INFO: Cannot find component with identifier "sub_Screen1:screen1Form:masterTable" in view.
        Dec 12, 2011 3:40:13 PM org.icefaces.ace.util.ComponentUtils findClientIds
        INFO: Cannot find component with identifier "sub_Screen1:screen1Form:dtlDvdr" in view.

        Show
        Ted Goddard added a comment - Dec 12, 2011 3:40:13 PM org.icefaces.ace.util.ComponentUtils findClientIds INFO: Cannot find component with identifier "sub_Screen1:screen1Form:masterTable" in view. Dec 12, 2011 3:40:13 PM org.icefaces.ace.util.ComponentUtils findClientIds INFO: Cannot find component with identifier "sub_Screen1:screen1Form:dtlDvdr" in view.
        Hide
        Ted Goddard added a comment -

        JavaScript for the DataTable appears to generate the component IDs that are not found:

        <script type="text/javascript">var rtrvdTbl = new ice.ace.DataTable('sub_Screen1:screen1Form:masterTable',{formId:'sub_Screen1:screen1Form',filterEvent:'change',configPanel:'sub_Screen1:screen1Form:j_idt31',paginator:new YAHOO.widget.Paginator({rowsPerPage:5,totalRecords:19,initialPage:1,containers:['sub_Screen1:screen1Form:masterTable_paginatortop','sub_Screen1:screen1Form:masterTable_paginatorbottom'],template:'

        {CurrentPageReport}

        {FirstPageLink}

        {PreviousPageLink}

        {PageLinks}

        {NextPageLink}

        {LastPageLink}

        {RowsPerPageDropdown}

        ',rowsPerPageOptions : [5,15,30],alwaysVisible:false}),selectionMode:'single',instantSelect:true,panelExpansion:true,behaviors:{select:function() {ice.ace.ab(

        {"source":"sub_Screen1:screen1Form:masterTable","execute":((arguments[1]) ? arguments[1] + ' ' + 'sub_Screen1:screen1Form:masterTable' : 'sub_Screen1:screen1Form:masterTable'),"render":((arguments[2]) ? arguments[2] + ' ' + 'sub_Screen1:screen1Form:dtlDvdr' : 'sub_Screen1:screen1Form:dtlDvdr'),"event":"select","params":arguments[0]}

        );}}});</script>

        Show
        Ted Goddard added a comment - JavaScript for the DataTable appears to generate the component IDs that are not found: <script type="text/javascript">var rtrvdTbl = new ice.ace.DataTable('sub_Screen1:screen1Form:masterTable',{formId:'sub_Screen1:screen1Form',filterEvent:'change',configPanel:'sub_Screen1:screen1Form:j_idt31',paginator:new YAHOO.widget.Paginator({rowsPerPage:5,totalRecords:19,initialPage:1,containers: ['sub_Screen1:screen1Form:masterTable_paginatortop','sub_Screen1:screen1Form:masterTable_paginatorbottom'] ,template:' {CurrentPageReport} {FirstPageLink} {PreviousPageLink} {PageLinks} {NextPageLink} {LastPageLink} {RowsPerPageDropdown} ',rowsPerPageOptions : [5,15,30] ,alwaysVisible:false}),selectionMode:'single',instantSelect:true,panelExpansion:true,behaviors:{select:function() {ice.ace.ab( {"source":"sub_Screen1:screen1Form:masterTable","execute":((arguments[1]) ? arguments[1] + ' ' + 'sub_Screen1:screen1Form:masterTable' : 'sub_Screen1:screen1Form:masterTable'),"render":((arguments[2]) ? arguments[2] + ' ' + 'sub_Screen1:screen1Form:dtlDvdr' : 'sub_Screen1:screen1Form:dtlDvdr'),"event":"select","params":arguments[0]} );}}});</script>
        Ken Fyten made changes -
        Fix Version/s 3.0 [ 10241 ]
        Assignee Priority P1
        Assignee Mark Collette [ mark.collette ]
        Ken Fyten made changes -
        Environment ICEfaces 3.0 RC1, Williams App and POC ICEfaces 3.0 RC1, Williams App and POC, FireFox browser
        Arran Mccullough made changes -
        Attachment javascript-error.JPG [ 13869 ]
        Arran Mccullough made changes -
        Field Original Value New Value
        Salesforce Case [5007000000JOi8w]
        Arran Mccullough created issue -

          People

          • Assignee:
            Ted Goddard
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: