ICEfaces
  1. ICEfaces
  2. ICE-5003

Add source-code and JavaDoc to the ICEfaces Maven distributions

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2
    • Fix Version/s: 3.1
    • Component/s: Release
    • Labels:
      None
    • Environment:
      Maven2

      Description

      It would be beneficial to add the ICEfaces source code and JavaDoc to the public Maven2 repository distributions.

        Issue Links

          Activity

          Hide
          Ken Fyten added a comment -

          Contribution from ehillman:

          For your consideration, I've attached a patch to the core and component
          build.xml scripts that create a jar file (each) that contains their source
          code. These get build to each dist directory.

          Then these files can be deployed along with their appropriate artifact using
          the mvn deploy:deploy-file command, being sure to use the classifier option.
          For example, I can run the following from a command line...

          1. Generate the sources jar
            ant -f $ICEFACES_SRC_DIR/core/build.xml sources-jar
            mvn deploy:deploy-file
            -Dfile=$ICEFACES_SRC_DIR/core/dist/icefaces-sources.jar
            -DgroupId=org.icefaces -DartifactId=icefaces -Dversion=$ICEFACES_VERSION \
            -Dclassifier=sources -Dpackaging=jar -Durl=$REPOSITORY_URL
            -DrepositoryId=$REPOSITORY_ID

          If ICEfaces deployed the source files for each artifact as well, I believe
          it will be valued by the maven community using your artifacts.

          Thanks,
          Ed

          Show
          Ken Fyten added a comment - Contribution from ehillman: For your consideration, I've attached a patch to the core and component build.xml scripts that create a jar file (each) that contains their source code. These get build to each dist directory. Then these files can be deployed along with their appropriate artifact using the mvn deploy:deploy-file command, being sure to use the classifier option. For example, I can run the following from a command line... Generate the sources jar ant -f $ICEFACES_SRC_DIR/core/build.xml sources-jar mvn deploy:deploy-file -Dfile=$ICEFACES_SRC_DIR/core/dist/icefaces-sources.jar -DgroupId=org.icefaces -DartifactId=icefaces -Dversion=$ICEFACES_VERSION \ -Dclassifier=sources -Dpackaging=jar -Durl=$REPOSITORY_URL -DrepositoryId=$REPOSITORY_ID If ICEfaces deployed the source files for each artifact as well, I believe it will be valued by the maven community using your artifacts. Thanks, Ed
          Hide
          Arran Mccullough added a comment -

          Addition comment:

          Please note: I discovered myself that when deploying the files in this sequence

          mvn deploy:deploy-file <artifact file>
          mvn deploy:deploy-file <source JAR>

          I needed to use the -DgeneratePom=false option for the second command (the command that deploys the Source jar). Otherwise, the original POM file gets replaced, losing any dependency delcarations the original POM might have had. Which makes subsequent compiles fail.

          Show
          Arran Mccullough added a comment - Addition comment: Please note: I discovered myself that when deploying the files in this sequence mvn deploy:deploy-file <artifact file> mvn deploy:deploy-file <source JAR> I needed to use the -DgeneratePom=false option for the second command (the command that deploys the Source jar). Otherwise, the original POM file gets replaced, losing any dependency delcarations the original POM might have had. Which makes subsequent compiles fail.
          Hide
          Deryk Sinotte added a comment -

          Resolving as fixed. The improvements done through ICE-8230 include adding source and javadoc jars for all the sub-projects except ICEpush.

          Show
          Deryk Sinotte added a comment - Resolving as fixed. The improvements done through ICE-8230 include adding source and javadoc jars for all the sub-projects except ICEpush.

            People

            • Assignee:
              Deryk Sinotte
              Reporter:
              Ken Fyten
            • Votes:
              3 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: