Details
Bug
Minor
Description
In IE6-7 browsers empty forms (for example after modal popup is closed) are displayed with one line of empty area
- this area should not be visible/
Example of empty form after inner modal is closed
<FORM class="iceFrm" id="ts3" onsubmit="return false;" action="javascript:;" method="post" class="iceFrm" enctype="application/x-www-form-urlencoded">
<INPUT type="hidden" name="ts3" value="ts3" /><INPUT type="hidden" name="icefacesCssUpdates" value="" />
<DIV id="ts3:stateSavingMarker">
<INPUT id="javax.faces.ViewState" type="hidden" name="javax.faces.ViewState" value="1" />
<INPUT type="hidden" name="javax.faces.RenderKitId" value="ICEfacesRenderKit" />
</DIV>
<DIV id="ts3hdnFldsDiv" style="DISPLAY: none"></DIV>
</FORM>
As you see div id="ts3:stateSavingMarker" should also got style="DISPLAY: none"
Patch for FormRendered.java
line 390
root.appendChild( n );
((Element) n).setAttribute( "id", id );
> ((Element) n).setAttribute(HTML.STYLE_ATTR, "display:none;");
domWriter.trackMarkerNode( n );
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Above patch do not resolve problem.
Probably the problem is in new line signs printed between hidden attributes
like here.
"
</div>
<div id="ts3hdnFldsDiv"
"
Is any workaround?
The same problem is described also in DomUtils.java
// We don't add the newline if the next tag is a TD,
// because when rendering our tabbedPane, if there's
// any whitespace between the adjacent TDs, then
// Internet Explorer will add vertical spacing
// Also same for some other tags to avoid extra space (JIRA ICE-1351)
Another alternative.
Form with rendered=false should got style="display:none"
Final patch for this problem.
Problem sometimes occurs in IE6-8 on complex pages with many empty forms - empty because inner modals are not rendered. Style fix with display=none doesn't work but another width/height works well.
File core\src\com\icesoft\faces\renderkit\dom_html_basic\FormRenderer.java
code around row 216
root.appendChild( n );
((Element) n).setAttribute( "id", id );
218d217
< ((Element) n).setAttribute(HTML.STYLE_ATTR, "width:0px;height:0px;");
domWriter.trackMarkerNode( n );
}
Verified with success using component showcase jsp: the style attribute for icefrm:stateSavingMarker is "width:0px;height:0px;"
Tested on 1.8.2 build 4 using TE6 and 7
Empty form view from iedeveloper