[#ICE-4428] REGRESSION - navigation rule: redirect from forwarded page doesn't work

ICEfaces

REGRESSION - navigation rule: redirect from forwarded page doesn't work

Created: 27/Apr/09 05:01 PM Updated: 07/Jan/10 12:07 PM

Component/s:

Framework

Affects Version/s:

1.7.2-SP2, 1.8

Fix Version/s:

1.8.1

Environment:

ICEfaces 1.7.2-SP1 - 1.8. Also doesn't work at all on Glassfish v2.1.

Support Customer Ref. #s:	5157
Support Case References:	https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=5157

Description

« Hide

The regression test case for ~~ICE-3502~~ is failing with latest trunk, ICEfaces 1.7.2-SP1 release (since 1.7.2-SP1). This was fixed in 1.7.2 originally.

-----------

if navigate from page A to page B using forward and then redirect from page B back to page A, it stays on the same page. see attached test case

All

Comments

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Deryk Sinotte added a comment - 27/Apr/09 05:08 PM

Please review test case to ensure it's testing the correct behaviour. If so, proceed to investigate the issue.

[ Permlink | « Hide ]

Mircea Toma added a comment - 28/Apr/09 06:11 PM

The test case for ~~ICE-3502~~ is executing in effect a forward and then a page reload because the forward won't change the URL of the rendered page. Issues ~~ICE-3886~~, ~~ICE-3691~~, and ~~ICE-3886~~ covered exactly this use case.

[ Permlink | « Hide ]

Mircea Toma added a comment - 28/Apr/09 06:13 PM

In ~~ICE-3691~~ is mentioned that the fixes are to be back-ported to 1.7 branch thus explaining why 1.7.2 has the same behavior as 1.8.

[ Permlink | « Hide ]

Mircea Toma added a comment - 28/Apr/09 06:24 PM - edited

The fixes for ~~ICE-3886~~, ~~ICE-3691~~, and ~~ICE-3886~~ changed somewhat the behavior of page reload we had in 1.7. But as it was explained also in ~~ICE-3907~~ the behavior of page reload is different if concurrentDOMViews=true, the views are not re-used on page reload. By enabling concurrentDOMViews in ~~ICE-3502~~ test case it will make it run successfully.

[ Permlink | « Hide ]

Mircea Toma added a comment - 02/May/09 10:11 AM

Reset the last viewId on redirect. The fix makes ICEfaces in single-view mode behave like SUN-RI now.

[ Permlink | « Hide ]

Joanne Bai added a comment - 04/May/09 12:37 PM

Fix verified on ICEfaces trunk revision 18832

[ Permlink | « Hide ]

Ken Fyten added a comment - 20/May/09 11:57 AM

QA is reporting that this test is passing as expected for JSF 1.2, but is failing on Tomcat 5.5 with JSF 1.1. Please investigate.

[ Permlink | « Hide ]

Mircea Toma added a comment - 20/May/09 05:22 PM

In JSF 1.2 the ViewRoot is reset at the end of lifecycle and restored if necessary with the help of state management. When we introduced our own state management implementation it was decided keep around the ViewRoot in JSF 1.1 because there wasn't any state management available. The decision to not reset the ViewRoot in JSF 1.1 was introduced in ~~ICE-3980~~.

So now the ViewRoot is reset only on redirect so that RestoreViewPhase will create a new view based on the GET request path.

[ Permlink | « Hide ]

Mircea Toma added a comment - 26/May/09 08:59 AM

~~ICE-4428~~ Reset viewRoot only when running with JSF1.1.