ICEfaces
  1. ICEfaces
  2. ICE-3992

component-showcase errors with compressDOM

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8DR#2
    • Fix Version/s: 1.8RC1, 1.8
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      ICEfaces component-showcase, compressDOM

      Description


      The CDATA sections in the Facelets version of the application appear to be passed into the DOM as text nodes, resulting in difficulties during DOM compression due to normalization.

      The candidate fix is to use < escaping rather than CDATA escaping.

        Activity

        Hide
        Ted Goddard added a comment -

        common-web/WEB-INF/includes/content/en/header.jspx contains the line

        xmlns:jsp="http://java.sun.com/JSP/Page"

        This namespace is unused and is propagated into the DOM resulting in errors since namespacing for DOM compression is not enabled. It may be possible to enable namespaces in DOM compression, however the namespace is not desired in the output, so this will simply be changed in the input document.

        Show
        Ted Goddard added a comment - common-web/WEB-INF/includes/content/en/header.jspx contains the line xmlns:jsp="http://java.sun.com/JSP/Page" This namespace is unused and is propagated into the DOM resulting in errors since namespacing for DOM compression is not enabled. It may be possible to enable namespaces in DOM compression, however the namespace is not desired in the output, so this will simply be changed in the input document.
        Hide
        Ted Goddard added a comment -

        DOMResponseWriter would be able to collect open text sections as they are written, so a tree-level normalize() step is likely not necessary for the general case.

        Show
        Ted Goddard added a comment - DOMResponseWriter would be able to collect open text sections as they are written, so a tree-level normalize() step is likely not necessary for the general case.
        Hide
        Mandeep Hayher added a comment -

        Tested successfully on ICEFaces 1.8 RC1 build2, jsp version component-showcase & Tomcat5.
        Showcase was tested with compressDOM=true.

        Show
        Mandeep Hayher added a comment - Tested successfully on ICEFaces 1.8 RC1 build2, jsp version component-showcase & Tomcat5. Showcase was tested with compressDOM=true.

          People

          • Assignee:
            Unassigned
            Reporter:
            Ted Goddard
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: