Issue Details (XML | Word | Printable)

Key: ICE-3442
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Frank Ye
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
ICEfaces

Component saveState restoreState

Created: 22/Aug/08 01:42 PM   Updated: 10/Apr/09 11:27 AM
Component/s: Components
Affects Version/s: None
Fix Version/s: 1.8DR#2, 1.8

Environment: any
Issue Links:
Dependency
 


 Description  « Hide
saveState and restoreState with components

 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Frank Ye added a comment - 22/Aug/08 01:43 PM
state saving

Frank Ye added a comment - 27/Aug/08 12:44 PM
Mock container is created for a few tests to audit the current situations related to component saveState and restoreState.

#1. Using StateManageImpl from jsf12 to confirm the specific properties
#2. Using MockSerializedView to store tree as well as state for wirteObject and readObject procedure


Ken Fyten added a comment - 28/Aug/08 04:31 PM
Need to manually review each component to ensure state-saving of each component's fields is being done correctly.

Subsequently need to generate automated tests to ensure state-saving is working in an on-going basis.

Frank Ye added a comment - 28/Aug/08 05:11 PM
mock tests

Adnan Durrani added a comment - 09/Sep/08 05:26 PM
save/restore state fixed for the required properties of the following components.

Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlForm.java
Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlMessage.java
Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlMessages.java
Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlOutputFormat.java
Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlPanelGroup.java
Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlSelectManyListbox.java
Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlPanelGroup.java
Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlForm.java
Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlMessage.java
Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlMessages.java
Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlOutputFormat.java
Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlSelectManyListbox.java
Completed: At revision: 17531

Mark Collette added a comment - 10/Sep/08 11:58 AM
Subversion 17535
icefaces\component\src\com\icesoft\faces\component\ext\HtmlSelectManyMenu.java
Subversion 17536
icefaces\component\src\com\icesoft\faces\component\ext\HtmlSelectOneListbox.java
Subversion 17537
icefaces\component\src\com\icesoft\faces\component\ext\HtmlSelectOneMenu.java
Subversion 17540
icefaces\component\src\com\icesoft\faces\component\style\OutputStyle.java
icefaces\component\src\com\icesoft\faces\component\paneldivider\PanelDivider.java

Mark Collette added a comment - 10/Sep/08 02:52 PM
Subversion 17541
icefaces\component\src\com\icesoft\faces\component\paneldivider\PanelDivider.java

Mark Collette added a comment - 06/Oct/08 12:19 PM
TRUNK
Subversion 17707
icefaces\component\src\com\icesoft\faces\component\ext\HeaderRow.java
icefaces\component\src\com\icesoft\faces\component\ext\HtmlCommandButton.java
icefaces\component\src\com\icesoft\faces\component\outputprogress\OutputProgress.java
icefaces\component\src\com\icesoft\faces\component\panelborder\PanelBorder.java
icefaces\component\src\com\icesoft\faces\component\panelcollapsible\PanelCollapsible.java
icefaces\component\src\com\icesoft\faces\component\panellayout\PanelLayout.java
icefaces\component\src\com\icesoft\faces\component\portlet\Portlet.java

Mark Collette added a comment - 06/Oct/08 01:23 PM
In order to save and restore the state for OutputChart, I had to make some changes to how it managed its image resource.

TRUNK
Subversion 17713
icefaces\component\src\com\icesoft\faces\component\outputchart\AbstractChart.java
icefaces\component\src\com\icesoft\faces\component\outputchart\ChartResource.java
icefaces\component\src\com\icesoft\faces\component\outputchart\OutputChart.java
icefaces\core\src\com\icesoft\faces\context\ByteArrayResource.java

Adnan Durrani added a comment - 21/Oct/08 03:53 PM
Trunk revision: 17799 [MockTestCase is using our own MockExternalContext]

Mark Collette added a comment - 27/Oct/08 02:12 PM
Starting to fix failures found with ICE-3696's test.

TRUNK
Subversion 17832
icefaces\component\src\com\icesoft\faces\component\ext\UIColumn.java
icefaces\component\src\com\icesoft\faces\component\inputfile\InputFile.java

Mark Collette added a comment - 27/Oct/08 07:16 PM
For ICE-3696's test to work properly, the following classes had to be augmented to properly implement a deep version of Object.equals(Object). Resource, UpdatableProperty, Effect, CurrentStyle.

TRUNK
Subversion 17847
icefaces\component\src\com\icesoft\faces\component\outputchart\ChartResource.java
icefaces\component\src\com\icesoft\faces\utils\UpdatableProperty.java
icefaces\core\src\com\icesoft\faces\context\ByteArrayResource.java
icefaces\core\src\com\icesoft\faces\context\effects\Fade.java
icefaces\core\src\com\icesoft\faces\context\effects\Puff.java
icefaces\core\src\com\icesoft\faces\context\effects\EffectQueue.java
icefaces\core\src\com\icesoft\faces\context\effects\CurrentStyle.java
icefaces\core\src\com\icesoft\faces\context\effects\Appear.java
icefaces\core\src\com\icesoft\faces\context\effects\Squish.java
icefaces\core\src\com\icesoft\faces\context\effects\Grow.java
icefaces\core\src\com\icesoft\faces\context\effects\Focus.java
icefaces\core\src\com\icesoft\faces\context\effects\BlindDown.java
icefaces\core\src\com\icesoft\faces\context\effects\Scale.java
icefaces\core\src\com\icesoft\faces\context\effects\SlideDown.java
icefaces\core\src\com\icesoft\faces\context\effects\Shake.java
icefaces\core\src\com\icesoft\faces\context\effects\DropOut.java
icefaces\core\src\com\icesoft\faces\context\effects\SwitchOff.java
icefaces\core\src\com\icesoft\faces\context\effects\BlindUp.java
icefaces\core\src\com\icesoft\faces\context\effects\BlankEffect.java
icefaces\core\src\com\icesoft\faces\context\effects\EffectsArguments.java
icefaces\core\src\com\icesoft\faces\context\effects\SlideUp.java
icefaces\core\src\com\icesoft\faces\context\effects\Move.java
icefaces\core\src\com\icesoft\faces\context\effects\Highlight.java
icefaces\core\src\com\icesoft\faces\context\effects\Opacity.java
icefaces\core\src\com\icesoft\faces\context\effects\Pulsate.java
icefaces\core\src\com\icesoft\faces\context\effects\Fold.java
icefaces\core\src\com\icesoft\faces\context\effects\Effect.java
icefaces\core\src\com\icesoft\faces\context\effects\Shrink.java
icefaces\core\src\com\icesoft\faces\util\CoreUtils.java