ICEfaces
  1. ICEfaces
  2. ICE-2684

fix problems in id generation for list.xhtml.ftl and view.xhtml.ftl

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:
      Seam
    • Workaround Exists:
      Yes
    • Workaround Description:
      manually fix id's

      Description

      look at id's for line 110 on both files. Have to get fixed and back to jboss-seam people before release of 2.0.1.GA

        Activity

        Hide
        Judy Guglielmin added a comment -

        Also should change the TimerBeanImpl as the ViewListener interface is deprecated (change to DisposableBean interface...but I don't think we really need it since we have @Remove and @Destroy annotations to work with...

        Show
        Judy Guglielmin added a comment - Also should change the TimerBeanImpl as the ViewListener interface is deprecated (change to DisposableBean interface...but I don't think we really need it since we have @Remove and @Destroy annotations to work with...
        Hide
        Judy Guglielmin added a comment -

        edit xhtml page has partialSubmit="true" outside of ice:inputText for property id's.

        Show
        Judy Guglielmin added a comment - edit xhtml page has partialSubmit="true" outside of ice:inputText for property id's.
        Hide
        Judy Guglielmin added a comment -

        changes in s:decorate has changed the way id's are rendered, so must look at id's to ensure all fields have id's for selenium testing. may as well do it at same time.

        Show
        Judy Guglielmin added a comment - changes in s:decorate has changed the way id's are rendered, so must look at id's to ensure all fields have id's for selenium testing. may as well do it at same time.
        Hide
        Judy Guglielmin added a comment -

        view.xhtml.ftl:- change line 110 to
        <ice:column id="view$

        {parentParentPojo.identifierProperty.name}

        ColumnName">
        edit.xhtml.ftl:- change line 112 to
        <ice:column id="editColumn$

        {componentProperty.name}

        Id">
        editproperty.xhtml.ft:- reverse order of lines 116 & 117 so that partialSubmit="true" comes before value="${....
        reverse order of lines 104 and 105 (again so partialSubmit comes before value="...)

        Show
        Judy Guglielmin added a comment - view.xhtml.ftl:- change line 110 to <ice:column id="view$ {parentParentPojo.identifierProperty.name} ColumnName"> edit.xhtml.ftl:- change line 112 to <ice:column id="editColumn$ {componentProperty.name} Id"> editproperty.xhtml.ft:- reverse order of lines 116 & 117 so that partialSubmit="true" comes before value="${.... reverse order of lines 104 and 105 (again so partialSubmit comes before value="...)
        Hide
        Judy Guglielmin added a comment -

        get rid of icefaces/src/TimerBean.java (interface not required).

        Update TimerBeanImpl:-

        1) eliminate implementing ViewListener interface so just have:-
        public class TimerBeanImpl implements Renderable, Serializable{
        also delete line 174 (state.addViewListener(this)) ...it's not required for cleanup of IntervalRenderer since Seam has the @Remove/@Destroy for clean up of IntervalRenderer.

        Show
        Judy Guglielmin added a comment - get rid of icefaces/src/TimerBean.java (interface not required). Update TimerBeanImpl:- 1) eliminate implementing ViewListener interface so just have:- public class TimerBeanImpl implements Renderable, Serializable{ also delete line 174 (state.addViewListener(this)) ...it's not required for cleanup of IntervalRenderer since Seam has the @Remove/@Destroy for clean up of IntervalRenderer.
        Hide
        Judy Guglielmin added a comment -

        Done in for 2.0 branch (in time for 2.0.2.CR2 release) and Seam trunk (after 2.1.0.A1 release).

        Also added in resizable columns for ice:dataTable

        Show
        Judy Guglielmin added a comment - Done in for 2.0 branch (in time for 2.0.2.CR2 release) and Seam trunk (after 2.1.0.A1 release). Also added in resizable columns for ice:dataTable

          People

          • Assignee:
            Unassigned
            Reporter:
            Judy Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: