ICEpdf
  1. ICEpdf
  2. PDF-137

Annotation Border Painting Regression

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0 - Beta
          • Fix Version/s: 4.0
          • Component/s: Core/Parsing
          • Labels:
            None
          • Environment:
            any

            Description

            The image compare test showed an issue where some annotations where incorrectly getting borders painted. I took a closer look at this as this was a regression on 3.1.2. The problems turned out to be two fold, first we where apply borders to any annotation that had a border colour specfied, which is only valid for Link annotaionts. The second issue was related to new features added for 4.0. Basically we where painting the border around line, square, circle polygon and polyline shapes when a border was specified. This is technically correct but acrobat doesn't point a border for these types, you can edit the property but it has no effect. So I carried this no paint policy over to ICEpdf for these types of annotations. There is nothing explicit in the spec as to what is the correct behaviour.

              Activity

              Repository Revision Date User Message
              ICEsoft Public SVN Repository #20306 Thu Jan 21 09:53:27 MST 2010 patrick.corless PDF-137 fixed an issue where some types annotation shouldn't have a border painting even if specified in the BS dictionary. Also fixed a bug where all annotation where given a border if a color was specfied, this should only apply to link annotations.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/SwingController.java
              Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/annotations/AnnotationState.java
              Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/annotations/BorderStyle.java
              Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/annotations/Annotation.java

                People

                • Assignee:
                  Patrick Corless
                  Reporter:
                  Patrick Corless
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: