ICEpdf
  1. ICEpdf
  2. PDF-121

Support search highlighting painting during printing

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0 - Beta
          • Fix Version/s: 4.0
          • Component/s: Core/Parsing
          • Labels:
            None
          • Environment:
            Search for a term using search highlight and print a page that has a hit on it. The printed page should have the search highlight words on it.

            Description

            This came in though the forums. When I wrote the search highlight code I was only considering the screen representation and didn't cut the paint code in the rendering code and as a result search terms are not show when printing. As the form post suggested, this would be a nice feature have a available when printing.

              Activity

              Ascending order - Click to sort in descending order
              Patrick Corless created issue -
              Patrick Corless made changes -
              Field Original Value New Value
              Salesforce Case []
              Fix Version/s 4.0 [ 10222 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #20209 Wed Jan 13 11:43:16 MST 2010 patrick.corless PDF-121 updated Page.paint(..) call to take an extra parameter to control if highlighting will be painted during a page paint. Rule of thumb viewer does the painting in the PaveViewComponentImp.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/views/swing/PageViewComponentImpl.java
              Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/views/common/TextSelectionPageHandler.java
              Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/Page.java
              Hide
              Permalink
              Patrick Corless added a comment -

              Updated the Page.paint method to take an optional boolean var to control whether or not the page is responsible for painting the text highlight state, this flag is similar to annotation painting flag. The reason for the two flags is that the interactive features search highlight and annotation editing that takes place PageViewComponentImp is best handled by the view and not the core.

              However for printing and page captures we need to print the annotation and highlight state via the core and thus the flags can be enabled. If a page paint method does not specify boolean paintAnnotations or boolean paintSearchHighlight properties then it is assumed that the annotation and search hightlight graphcis are painted if present.

              Show
              Patrick Corless added a comment - Updated the Page.paint method to take an optional boolean var to control whether or not the page is responsible for painting the text highlight state, this flag is similar to annotation painting flag. The reason for the two flags is that the interactive features search highlight and annotation editing that takes place PageViewComponentImp is best handled by the view and not the core. However for printing and page captures we need to print the annotation and highlight state via the core and thus the flags can be enabled. If a page paint method does not specify boolean paintAnnotations or boolean paintSearchHighlight properties then it is assumed that the annotation and search hightlight graphcis are painted if present.
              Patrick Corless made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #52082 Wed Nov 15 07:20:27 MST 2017 patrick.corless PDF-121 added missing currentPageChanger.dispose() call to TwoPageView
              clean up call. Addresses memory leak.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/TwoPageView.java

                People

                • Assignee:
                  Patrick Corless
                  Reporter:
                  Patrick Corless
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: