ICEfaces
  1. ICEfaces
  2. ICE-7678

Add Find feature to ice:dataTable

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-1.8.2.GA_P03
    • Fix Version/s: 3.0, EE-1.8.2.GA_P04
    • Labels:
      None
    • Environment:
      ICEfaces 3, ice:dataTable component
    • Assignee Priority:
      P2
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

      Description

      It would be a useful addition to the ice:dataTable component if application developers could implement a Find function that would search for a matching substring within a set of specified columns to include in the search. Upon finding the first match, the dataTable would navigate to ensure that row was visible on the screen, and use an effect to highlight the matching row.

      It would be the responsibility of the application to provide the search string and trigger the find operation via new APIs on the dataTable component. This approach provides the maximum flexibility for applications in terms of how the find text is acquired from the user, etc.


      In order to provide a Search/Find capability to the ace:dataTable, we need to add new component APIs as described below:


      double findRow(String str, Array columns, double startRow)

      The findRow API will accept a String argument ("str") to locate within the specified dataTable "columns". An optional startRow argument can be specified to begin searching at a specific row number (this enables a "Find Next" type functionality). The return value for this API is the first row number that has a column string value that matches the str argument value anywhere in the string. If no match is found, -1 is returned.

      Also might make sense to make the actual match condition a config. parameter in the findRow api. Possible settings would be Anywhere in String, StartsWith, endsWith.


      void navigateToRow( double row, EffectQueue highlightEffect)

      The navigateToRow API will accept a row number to navigate the datatable to such that the specified row number is made visible in the datatable, either via pagination to the page that contains the specified row, or via scrolling a scrollable datatable until the specified row is within the visible region on the page. An optional highlightEffect type may be specified that will be applied to the row once it is visible to draw the user's attention to the row.

        Activity

        Ken Fyten created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Salesforce Case []
        Affects [Documentation (User Guide, Ref. Guide, etc.)]
        Assignee Priority P2
        Description API Development: Senior ICEsoft Component Developers will spend approximately 30 hrs, extending the API of the existing ice:datatable component in ICEfaces EE 1.8.2 patch 3 to accommodate the following features:

        double findRow(String str, Array columns, double startRow) - The findRow API will accept a String argument ("str") to locate within the specified dataTable "columns". An optional startRow argument can be specified to begin searching at a specific row number (this enables a "Find Next" type functionality). The return value for this API is the first row number that has a column string value that matches the str argument value anywhere in the string. If no match is found, -1 is returned.
        void navigateToRow( double row, EffectQueue highlightEffect) - The navigateToRow API will accept a row number to navigate the datatable to such that the specified row number is made visible in the datatable, either via pagination to the page that contains the specified row, or via scrolling a scrollable datatable until the specified row is within the visible region on the page. An optional highlightEffect type may be specified that will be applied to the row once it is visible to draw the user's attention to the row.
        It would be a useful addition to the ace:dataTable component if application developers could implement a Find function that would search for a matching substring within a set of specified columns to include in the search. Upon finding the first match, the dataTable would navigate to ensure that row was visible on the screen, and use an effect to highlight the matching row.

        It would be the responsibility of the application to provide the search string and trigger the find operation via new APIs on the dataTable component. This approach provides the maximum flexibility for applications in terms of how the find text is acquired from the user, etc.


        In order to provide a Search/Find capability to the ace:dataTable, we need to add new component APIs as described below:


        double findRow(String str, Array columns, double startRow)

        The findRow API will accept a String argument ("str") to locate within the specified dataTable "columns". An optional startRow argument can be specified to begin searching at a specific row number (this enables a "Find Next" type functionality). The return value for this API is the first row number that has a column string value that matches the str argument value anywhere in the string. If no match is found, -1 is returned.

        Also might make sense to make the actual match condition a config. parameter in the findRow api. Possible settings would be Anywhere in String, StartsWith, endsWith.


        void navigateToRow( double row, EffectQueue highlightEffect)

        The navigateToRow API will accept a row number to navigate the datatable to such that the specified row number is made visible in the datatable, either via pagination to the page that contains the specified row, or via scrolling a scrollable datatable until the specified row is within the visible region on the page. An optional highlightEffect type may be specified that will be applied to the row once it is visible to draw the user's attention to the row.

        Assignee Nils Lundquist [ nils.lundquist ]
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 3.1 [ 10312 ]
        Affects Version/s 3.0 [ 10241 ]
        Affects Version/s 3.1 [ 10312 ]
        Ken Fyten made changes -
        Summary Add Find feature to ace:dataTable API Add Find feature to ice:dataTable
        Environment ICEfaces 3, ace:dataTable component ICEfaces 3, ice:dataTable component
        Salesforce Case []
        Component/s Components [ 10012 ]
        Component/s ACE-Components [ 10050 ]
        Fix Version/s EE-1.8.2.GA_P04 [ 10280 ]
        Fix Version/s 3.0.1 [ 10282 ]
        Fix Version/s 3.1 [ 10312 ]
        Affects Version/s EE-1.8.2.GA_P03 [ 10251 ]
        Affects Version/s 3.0 [ 10241 ]
        Description It would be a useful addition to the ace:dataTable component if application developers could implement a Find function that would search for a matching substring within a set of specified columns to include in the search. Upon finding the first match, the dataTable would navigate to ensure that row was visible on the screen, and use an effect to highlight the matching row.

        It would be the responsibility of the application to provide the search string and trigger the find operation via new APIs on the dataTable component. This approach provides the maximum flexibility for applications in terms of how the find text is acquired from the user, etc.


        In order to provide a Search/Find capability to the ace:dataTable, we need to add new component APIs as described below:


        double findRow(String str, Array columns, double startRow)

        The findRow API will accept a String argument ("str") to locate within the specified dataTable "columns". An optional startRow argument can be specified to begin searching at a specific row number (this enables a "Find Next" type functionality). The return value for this API is the first row number that has a column string value that matches the str argument value anywhere in the string. If no match is found, -1 is returned.

        Also might make sense to make the actual match condition a config. parameter in the findRow api. Possible settings would be Anywhere in String, StartsWith, endsWith.


        void navigateToRow( double row, EffectQueue highlightEffect)

        The navigateToRow API will accept a row number to navigate the datatable to such that the specified row number is made visible in the datatable, either via pagination to the page that contains the specified row, or via scrolling a scrollable datatable until the specified row is within the visible region on the page. An optional highlightEffect type may be specified that will be applied to the row once it is visible to draw the user's attention to the row.

        It would be a useful addition to the ice:dataTable component if application developers could implement a Find function that would search for a matching substring within a set of specified columns to include in the search. Upon finding the first match, the dataTable would navigate to ensure that row was visible on the screen, and use an effect to highlight the matching row.

        It would be the responsibility of the application to provide the search string and trigger the find operation via new APIs on the dataTable component. This approach provides the maximum flexibility for applications in terms of how the find text is acquired from the user, etc.


        In order to provide a Search/Find capability to the ace:dataTable, we need to add new component APIs as described below:


        double findRow(String str, Array columns, double startRow)

        The findRow API will accept a String argument ("str") to locate within the specified dataTable "columns". An optional startRow argument can be specified to begin searching at a specific row number (this enables a "Find Next" type functionality). The return value for this API is the first row number that has a column string value that matches the str argument value anywhere in the string. If no match is found, -1 is returned.

        Also might make sense to make the actual match condition a config. parameter in the findRow api. Possible settings would be Anywhere in String, StartsWith, endsWith.


        void navigateToRow( double row, EffectQueue highlightEffect)

        The navigateToRow API will accept a row number to navigate the datatable to such that the specified row number is made visible in the datatable, either via pagination to the page that contains the specified row, or via scrolling a scrollable datatable until the specified row is within the visible region on the page. An optional highlightEffect type may be specified that will be applied to the row once it is visible to draw the user's attention to the row.

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27328 Mon Jan 23 16:52:18 MST 2012 nils.lundquist ICE-7678 - Added findRow and navigateToRow.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/HtmlDataTable.java
        Hide
        Nils Lundquist added a comment -

        Revision #27328
        ICE-7678 - Added findRow and navigateToRow.

        Added to icefaces/trunk. Forthcoming to IF 3.

        Show
        Nils Lundquist added a comment - Revision #27328 ICE-7678 - Added findRow and navigateToRow. Added to icefaces/trunk. Forthcoming to IF 3.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27337 Tue Jan 24 11:19:07 MST 2012 nils.lundquist ICE-7678 - Added row focusing to navigateToRow. Works in scrolling cases now.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/HtmlDataTable.java
        Hide
        Nils Lundquist added a comment -

        Revision #27337
        ICE-7678 - Added row focusing to navigateToRow. Works in scrolling cases now

        Show
        Nils Lundquist added a comment - Revision #27337 ICE-7678 - Added row focusing to navigateToRow. Works in scrolling cases now
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27477 Fri Jan 27 15:53:59 MST 2012 nils.lundquist ICE-7678 - Added findRow and navigateToRow API to compat and ace DataTables
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/HtmlDataTable.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27479 Fri Jan 27 16:25:33 MST 2012 nils.lundquist ICE-7678 - ACE navigateToRow API needed adjusting of pagination technique.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java
        Hide
        Nils Lundquist added a comment -

        Revision #27477
        ICE-7678 - Added findRow and navigateToRow API to compat and ace DataTables

        Show
        Nils Lundquist added a comment - Revision #27477 ICE-7678 - Added findRow and navigateToRow API to compat and ace DataTables
        Nils Lundquist made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27480 Fri Jan 27 17:05:53 MST 2012 nils.lundquist ICE-7678 - Fixed typo specific to 3.x Compat table.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/HtmlDataTable.java
        Ken Fyten made changes -
        Salesforce Case []
        Component/s ACE-Components [ 10050 ]
        Fix Version/s 3.0 [ 10241 ]
        Fix Version/s 3.0.1 [ 10282 ]
        Affects [Documentation (User Guide, Ref. Guide, etc.)] [Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial]
        Ken Fyten made changes -
        Salesforce Case []
        Security Private [ 10001 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27502 Mon Jan 30 12:25:08 MST 2012 nils.lundquist ICE-7678 - Added showcase example for findRow & navigateToRow.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/common-src/org/icefaces/application/showcase/view/resources/messages_es.properties
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/facelets-enh/src/org/icefaces/application/showcase/view/jaxb/resources/application_structure.xml
        Commit graph ADD /icefaces/trunk/icefaces/samples/component-showcase/common-web/WEB-INF/includes/examples/custom/dataTable-find.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/common-src/org/icefaces/application/showcase/view/resources/messages_de.properties
        Commit graph ADD /icefaces/trunk/icefaces/samples/component-showcase/common-src/org/icefaces/application/showcase/view/bean/examples/component/dataTable/DataTableFind.java
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/common-src/org/icefaces/application/showcase/view/resources/messages_en.properties
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/common-web/WEB-INF/faces-config-example-beans.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27512 Mon Jan 30 14:52:09 MST 2012 nils.lundquist ICE-7678 - ACE navigateToRow examples visually improved and fixed bug with switching search mode.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableFind.xhtml
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableFind.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/compat/dataTable/dataTableFind.xhtml
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/compat/dataTable/DataTableFind.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27514 Mon Jan 30 15:27:40 MST 2012 ken.fyten ICE-7678 - Added findRow and navigateToRow API to compat and ace DataTables.
        Files Changed
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/HtmlDataTable.java
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27529 Mon Jan 30 16:20:09 MST 2012 nils.lundquist ICE-7678 - Reordered Find example alphabetically.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/compat/dataTable/DataTableBean.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableBean.java
        Hide
        Carmen Cristurean added a comment - - edited

        Tested in the showcase application using ICEfaces3 revision 27509, and as browsers: IE7/IE8, FF9, Chrome16.

        1. ace:dataTable: If using the default effect (Highlight), the highlight color is barely visible in some of the browsers.
        In comparison, for the ice:dataTable the row is stronger highlighted and the highlight can be noticed to last for a longer time.

        2. ace:dataTable: Pulsate effect is not visible in IE7.

        3. ace:dataTable & ice:dataTable: when searching for a string which is supposed to return a single result from table, then every second click on the 'Find Next' button will find the result row. Unsure if this is the desired behaviour?

        Steps to reproduce:
        -Search Query: yellow , leave all the other selections unchanged.
        -Clicking Find Next button -> first row with name='Yellowjacket' is returned.
        -Clicking again on 'Find Next' button -> nothing happens.
        -Clicking again on 'Find Next' button -> highlights again the first row.

        In this case, if there are no other rows containing the search string, maybe it would be suitable to have a message saying that no more result can be found, or that the search reached the end of the table?

        4. ice:dataTable: JS errors in IE browsers:
        clicking on the 'Find Next' button generates a JS error, when using particular query strings such as 'yellow':

        IE8:
        Webpage error details

        User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; MDDS; .NET4.0C)
        Timestamp: Mon, 30 Jan 2012 21:50:14 UTC

        Message: Exception thrown and not caught
        Line: 8
        Char: 52448
        Code: 0
        URI: http://localhost:8080/showcase/javax.faces.resource/icefaces-compat.js.jsf

        IE7: screenshot attached.

        5. ice:dataTable & ace:dataTable: 'Starts With, 'Ends With', 'Exact Match' do not appear to return the correct results.
        Selection options to reproduce 'Ends With':
        Search Query = t
        Case sensitive: unchecked (default)
        Columns to search: only 'Name' checked
        Search Type: Ends With
        Effect to use: Pulsate (tested in FF/Chrome where pulsate effect is visible).

        Using these selections the following will be found:
        ID=1 Yellowjacket (correct)
        ID=3 Hotshot (correct)
        ID=6 Vacationer (incorrect)

        Show
        Carmen Cristurean added a comment - - edited Tested in the showcase application using ICEfaces3 revision 27509, and as browsers: IE7/IE8, FF9, Chrome16. 1. ace:dataTable: If using the default effect (Highlight), the highlight color is barely visible in some of the browsers. In comparison, for the ice:dataTable the row is stronger highlighted and the highlight can be noticed to last for a longer time. 2. ace:dataTable: Pulsate effect is not visible in IE7. 3. ace:dataTable & ice:dataTable: when searching for a string which is supposed to return a single result from table, then every second click on the 'Find Next' button will find the result row. Unsure if this is the desired behaviour? Steps to reproduce: -Search Query: yellow , leave all the other selections unchanged. -Clicking Find Next button -> first row with name='Yellowjacket' is returned. -Clicking again on 'Find Next' button -> nothing happens. -Clicking again on 'Find Next' button -> highlights again the first row. In this case, if there are no other rows containing the search string, maybe it would be suitable to have a message saying that no more result can be found, or that the search reached the end of the table? 4. ice:dataTable: JS errors in IE browsers: clicking on the 'Find Next' button generates a JS error, when using particular query strings such as 'yellow': IE8: Webpage error details User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; MDDS; .NET4.0C) Timestamp: Mon, 30 Jan 2012 21:50:14 UTC Message: Exception thrown and not caught Line: 8 Char: 52448 Code: 0 URI: http://localhost:8080/showcase/javax.faces.resource/icefaces-compat.js.jsf IE7: screenshot attached. 5. ice:dataTable & ace:dataTable: 'Starts With, 'Ends With', 'Exact Match' do not appear to return the correct results. Selection options to reproduce 'Ends With': Search Query = t Case sensitive: unchecked (default) Columns to search: only 'Name' checked Search Type: Ends With Effect to use: Pulsate (tested in FF/Chrome where pulsate effect is visible). Using these selections the following will be found: ID=1 Yellowjacket (correct) ID=3 Hotshot (correct) ID=6 Vacationer (incorrect)
        Carmen Cristurean made changes -
        Attachment 1.png [ 14020 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27531 Mon Jan 30 16:55:32 MST 2012 nils.lundquist ICE-7678 - Added JavaDoc
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/HtmlDataTable.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27532 Mon Jan 30 17:15:31 MST 2012 ken.fyten ICE-7678 - Reordered Find example alphabetically.
        Files Changed
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableBean.java
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/compat/dataTable/DataTableBean.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27533 Mon Jan 30 17:15:51 MST 2012 ken.fyten ICE-7678 - Added Find API JavaDoc
        Files Changed
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/HtmlDataTable.java
        Hide
        Nils Lundquist added a comment - - edited

        I suspect the difference in browsers regarding issue #1 is due to javascript animation speed. I'd be surprised if it isn't something shared by the highlight effect of JQ in general. We could perhaps tune it to last a little longer in the future.

        Issues 3 & 5 were already addressed.

        Show
        Nils Lundquist added a comment - - edited I suspect the difference in browsers regarding issue #1 is due to javascript animation speed. I'd be surprised if it isn't something shared by the highlight effect of JQ in general. We could perhaps tune it to last a little longer in the future. Issues 3 & 5 were already addressed.
        Hide
        Nils Lundquist added a comment - - edited

        Cannot reproduce issue 4 in either browser. And neither effect of the ice table appears to work in IE7. I suspect this is a known limitation of the compat effects.

        Show
        Nils Lundquist added a comment - - edited Cannot reproduce issue 4 in either browser. And neither effect of the ice table appears to work in IE7. I suspect this is a known limitation of the compat effects.
        Hide
        Carmen Cristurean added a comment -

        Retested with ICEdfaces3 build 8, and here are the results regarding the above issues:

        1. &2. still exist, Pulsate effect does not seem to work also in IE8.

        3. In IE7, there is a different behaviour when the search cannot find any more results, no message renders on the page.

        This issue is resolved for the other browsers.

        4. Could not reproduce the JS error this time.

        5. 'Start with', 'Ends With' 'Contains' appear to be fixed.
        'Exact Match' does not return an exact match, it seem to return the same search results as 'Contains'.

        Show
        Carmen Cristurean added a comment - Retested with ICEdfaces3 build 8, and here are the results regarding the above issues: 1. &2. still exist, Pulsate effect does not seem to work also in IE8. 3. In IE7, there is a different behaviour when the search cannot find any more results, no message renders on the page. This issue is resolved for the other browsers. 4. Could not reproduce the JS error this time. 5. 'Start with', 'Ends With' 'Contains' appear to be fixed. 'Exact Match' does not return an exact match, it seem to return the same search results as 'Contains'.
        Hide
        Nils Lundquist added a comment -

        Please rereport issue 1,2 & 5 noting with either ace or compat tables.

        Show
        Nils Lundquist added a comment - Please rereport issue 1,2 & 5 noting with either ace or compat tables.
        Hide
        Carmen Cristurean added a comment -

        ICEfaces3 Build 10 testing results:

        1. ace:dataTable: If using the default effect (Highlight), the highlight color is barely visible in some of the browsers.

        2. ice:dataTable & ace:dataTable: Pulsate effect is not visible in IE7 and IE8.

        3. ice:dataTable: if search does not return a result, messages similar to the ones used for ace:dataTable may be implemented here:
        "Search starting at index 0 for "i" did not return a result."

        4. Could not reproduce the JS error anymore, this issues considered resolved.

        5. ice:dataTable & ace:dataTable:'Exact Match' does not return an exact match, it seems to return the same search results as 'Contains'.
        As example, searching for exact match for 'flash' will return name='Superflash' and name='Flash', in total 4 records. The same results are returned when searching for 'flash' with search type='Contains'.

        Show
        Carmen Cristurean added a comment - ICEfaces3 Build 10 testing results: 1. ace:dataTable: If using the default effect (Highlight), the highlight color is barely visible in some of the browsers. 2. ice:dataTable & ace:dataTable: Pulsate effect is not visible in IE7 and IE8. 3. ice:dataTable: if search does not return a result, messages similar to the ones used for ace:dataTable may be implemented here: "Search starting at index 0 for "i" did not return a result." 4. Could not reproduce the JS error anymore, this issues considered resolved. 5. ice:dataTable & ace:dataTable:'Exact Match' does not return an exact match, it seems to return the same search results as 'Contains'. As example, searching for exact match for 'flash' will return name='Superflash' and name='Flash', in total 4 records. The same results are returned when searching for 'flash' with search type='Contains'.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27552 Tue Jan 31 12:58:49 MST 2012 nils.lundquist ICE-7678 - Find demo select item contained typo.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableFind.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/compat/dataTable/DataTableFind.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27554 Tue Jan 31 13:15:35 MST 2012 nils.lundquist ICE-7678 - Fix to case insensitive mode of ice:dataTable find and added h:messages to the demo.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/compat/dataTable/dataTableFind.xhtml
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/HtmlDataTable.java
        Hide
        Nils Lundquist added a comment -

        5 was due to a typo in the demo. Now resolved. 3 has been fixed also.

        Show
        Nils Lundquist added a comment - 5 was due to a typo in the demo. Now resolved. 3 has been fixed also.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27565 Wed Feb 01 10:17:48 MST 2012 ken.fyten ICE-7678 - Fix to case insensitive mode of ice:dataTable find and added h:messages to the demo.
        Files Changed
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/compat/dataTable/DataTableFind.java
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableFind.java
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/HtmlDataTable.java
        Hide
        Carmen Cristurean added a comment - - edited

        Verified fixes for 3. and 5. above with ICEfaces3 revision 27562, and with ICEfaces3 build11, in IE8, FF9, Chrome16.

        Show
        Carmen Cristurean added a comment - - edited Verified fixes for 3. and 5. above with ICEfaces3 revision 27562, and with ICEfaces3 build11, in IE8, FF9, Chrome16.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #28752 Wed Apr 18 13:08:45 MDT 2012 nils.lundquist ICE-7678 - Fixed typo for showcase example exact match, and issue with case insensitive mode
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/common-src/org/icefaces/application/showcase/view/bean/examples/component/dataTable/DataTableFind.java
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/HtmlDataTable.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #28766 Thu Apr 19 10:26:28 MDT 2012 ken.fyten ICE-7678 - Added back commandSort Header demo entry that was accidently removed when Find demo was added.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/facelets-enh/src/org/icefaces/application/showcase/view/jaxb/resources/application_structure.xml

          People

          • Assignee:
            Nils Lundquist
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: