Details
Description
We need to review our strategy of directly subclassing interfaces rather than using the supplied abstract wrappers for delegation:
public class DOMRenderKit extends RenderKit vs public class DOMRenderKit extends RenderKitWrapper
public class DOMResponseWriter extends ResponseWriter vs public class DOMResponseWriter extends ResponseWriterWrapper
In many cases, using the wrapper would give us access to a delegate class where we could take advantage of existing code.
public class DOMRenderKit extends RenderKit vs public class DOMRenderKit extends RenderKitWrapper
public class DOMResponseWriter extends ResponseWriter vs public class DOMResponseWriter extends ResponseWriterWrapper
In many cases, using the wrapper would give us access to a delegate class where we could take advantage of existing code.
Issue Links
- blocks
-
ICE-5679 Standardize how ICEfaces detects and uses encoding
- Closed
Activity
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Assignee Priority | P1 |
Ken Fyten
made changes -
Fix Version/s | 2.0.0 [ 10230 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #21815 | Mon Jun 28 14:53:43 MDT 2010 | deryk.sinotte | |
Files Changed | ||||
MODIFY
/icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMPartialViewContext.java
MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/java/com/icesoft/faces/context/CompatDOMPartialViewContext.java |
Deryk Sinotte
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #21802 | Fri Jun 25 08:52:52 MDT 2010 | deryk.sinotte | |
Files Changed | ||||
MODIFY
/icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMResponseWriter.java
MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/BasicResponseWriter.java MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMPartialViewContext.java MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/render/DOMRenderKit.java MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/java/com/icesoft/faces/context/CompatDOMPartialViewContext.java |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #21776 | Mon Jun 21 11:32:33 MDT 2010 | deryk.sinotte | |
Files Changed | ||||
MODIFY
/icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/push/servlet/ICEfacesResourceHandler.java
MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/push/servlet/ICEpushResourceHandler.java |
Deryk Sinotte
made changes -
Salesforce Case | [] | |
Component/s | Framework [ 10013 ] | |
Assignee Priority | P1 |
Ken Fyten
made changes -
Assignee | Deryk Sinotte [ deryk.sinotte ] |
Deryk Sinotte
made changes -
Deryk Sinotte
made changes -
Field | Original Value | New Value |
---|---|---|
Salesforce Case | [] | |
Fix Version/s | 2.0-Beta [ 10231 ] |
Deryk Sinotte
created issue -
I've checked in the changes to the ResponseWriters so now everything that should likely be using wrappers is now converted.