ICEfaces
  1. ICEfaces
  2. ICE-5245

Update ICEFaces to work with Spring Security 3.0

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2, 1.8.2-EE-GA
    • Fix Version/s: 1.8.2-EE-GA_P01, 1.8.3
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEFaces + Spring Security 3.0
    • Affects:
      Compatibility/Configuration

      Description

      An update is required to detect Spring Security 3.0. A user patch has been located:

      static {
              try {
                  AcegiAuthenticationClass = Class.forName("org.acegisecurity.Authentication");
                  AuthenticationClass = AcegiAuthenticationClass;
                  Log.debug("Acegi Security detected.");
              } catch (Throwable t) {
                  Log.debug("Acegi Security not detected.");
              }
              try {
                  SpringAuthenticationClass = Class.forName("org.springframework.security.Authentication");
                  AuthenticationClass = SpringAuthenticationClass;
                  Log.debug("Spring Security detected.");
              } catch (Throwable t) {
                  Log.debug("Spring Security not detected.");
              }

             // New code below

              try {
                  SpringAuthenticationClass = Class.forName("org.springframework.security.core.Authentication");
                  AuthenticationClass = SpringAuthenticationClass;
                  Log.debug("Spring Security 3 detected.");
              } catch (Throwable t) {
                  Log.debug("Spring Security 3 not detected.");
              }

             // end patch

          }

        Activity

        Greg Dick created issue -
        Hide
        Greg Dick added a comment -

        Further changes are indicated in this blog posting for Spring Security 3.0

        http://datenschwanz.net/2009/12/29/icefaces-and-spring-web-flow/

        The suggested changes need to be evaluated for backward compatibility, etc.

        Show
        Greg Dick added a comment - Further changes are indicated in this blog posting for Spring Security 3.0 http://datenschwanz.net/2009/12/29/icefaces-and-spring-web-flow/ The suggested changes need to be evaluated for backward compatibility, etc.
        Hide
        Werner Mueller added a comment -

        could this be put on the roadmap for 1.8.2-EE-GA_P01 ?

        it's somewhat important for us too!

        Show
        Werner Mueller added a comment - could this be put on the roadmap for 1.8.2-EE-GA_P01 ? it's somewhat important for us too!
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #21071 Thu Mar 25 09:13:39 MDT 2010 greg.dick ICE-5245 Added support for Spring Security version 3
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/BridgeExternalContext.java
        Ken Fyten made changes -
        Field Original Value New Value
        Salesforce Case []
        Fix Version/s 1.8.2-EE-GA_P01 [ 10220 ]
        Fix Version/s 1.8.3 [ 10211 ]
        Affects [Compatibility/Configuration]
        Ken Fyten made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Greg Dick added a comment -

        I've added the code change as indicated above, but the download page for spring security 3.0.2 indicates it requires Spring Framework 3.0.1, which isn't supported by ICEFaces at this time.

        Show
        Greg Dick added a comment - I've added the code change as indicated above, but the download page for spring security 3.0.2 indicates it requires Spring Framework 3.0.1, which isn't supported by ICEFaces at this time.
        Hide
        Werner Mueller added a comment -

        I don't see a problem using spring 3 with icefaces 1.8.2 - we use that in a couple of projects and have no real issues with that combination (other than login)

        Show
        Werner Mueller added a comment - I don't see a problem using spring 3 with icefaces 1.8.2 - we use that in a couple of projects and have no real issues with that combination (other than login)
        Hide
        Isuru Perera added a comment -

        There is an issue with the fix.

        Please see my forum post http://www.icefaces.org/JForum/posts/list/0/16521.page#61829

        Thank you

        Show
        Isuru Perera added a comment - There is an issue with the fix. Please see my forum post http://www.icefaces.org/JForum/posts/list/0/16521.page#61829 Thank you
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Greg Dick
          • Votes:
            4 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: