ICEfaces
  1. ICEfaces
  2. ICE-4971

ice:panelDivider causes JS error when used in Liferay portlet in IE

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.1
    • Fix Version/s: 1.8.2-EE-Beta, 1.8.2-EE-GA, 1.8.3
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Liferay 5.2.3 + Tomcat 6 + IE7

      Description

      When using an ice:panelDivider in Liferay Portal, viewed in IE7 it causes a JS error to be reported by IE when it loads. The basic functionality continues to work but it looks like the error is related to sizing the panel divider properly.

      Even though changing the split direction works you can see that the split region for the horizontal direction doesn't stretch for the entire
      width of the pane. The JS error occurs in Ice.PanelDivider.adjustSecondPaneSize which confirms that the error is
      really related to Panel Divider JS code.
      1. screenshot-5.png
        176 kB
      2. screenshot-4.png
        174 kB
      3. screenshot-3.png
        165 kB
      4. screenshot-2.png
        41 kB
      5. screenshot-1.png
        145 kB

        Activity

        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P3
        Assignee Yip Ng [ yip.ng ]
        Ken Fyten made changes -
        Fix Version/s 1.8.2-EE-GA [ 10216 ]
        Ken Fyten made changes -
        Fix Version/s 1.8.2-EE-Beta [ 10215 ]
        yip.ng made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        yip.ng added a comment - - edited

        Seems in this particular scenario the the event for adjusting the dimensions of the divided panels occurred too soon. Somehow IE returns zero for some measurements even though the elements should have been parsed already.

        Changed to delay event handling until window onload event happens.

        Fixed. See screen shots 4 and 5.

        Show
        yip.ng added a comment - - edited Seems in this particular scenario the the event for adjusting the dimensions of the divided panels occurred too soon. Somehow IE returns zero for some measurements even though the elements should have been parsed already. Changed to delay event handling until window onload event happens. Fixed. See screen shots 4 and 5.
        yip.ng made changes -
        Attachment screenshot-5.png [ 12044 ]
        yip.ng made changes -
        Attachment screenshot-4.png [ 12043 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #19427 Thu Oct 15 13:52:38 MDT 2009 yip.ng ICE-4971: Fixed JS error in divider panel in portlet in IE.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/resizablePanelGrid.js
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 1.8.3 [ 10211 ]
        Fix Version/s 1.8.2 [ 10190 ]
        Hide
        yip.ng added a comment -

        After setting com.icesoft.faces.compressResources=false in web.xml, basic functionally is working, but the Microsoft Script Debugger still comes up blank.

        Show
        yip.ng added a comment - After setting com.icesoft.faces.compressResources=false in web.xml, basic functionally is working, but the Microsoft Script Debugger still comes up blank.
        Hide
        yip.ng added a comment -

        Seems it's not working well in FF either, although there are no errors in FF. See screenshot-3.

        Show
        yip.ng added a comment - Seems it's not working well in FF either, although there are no errors in FF. See screenshot-3.
        yip.ng made changes -
        Attachment screenshot-3.png [ 12015 ]
        yip.ng made changes -
        Attachment screenshot-2.png [ 12014 ]
        Hide
        yip.ng added a comment -

        Couldn't even see the basic functionality working. After clicking through a number of meaningless errors, I got the screen as in screenshot-1. If I tried to debug the errors, the Microsoft Script Debugger would come up as totally empty as in screenshot-2.

        Show
        yip.ng added a comment - Couldn't even see the basic functionality working. After clicking through a number of meaningless errors, I got the screen as in screenshot-1. If I tried to debug the errors, the Microsoft Script Debugger would come up as totally empty as in screenshot-2.
        yip.ng made changes -
        Attachment screenshot-1.png [ 12013 ]
        Ken Fyten made changes -
        Assignee Adnan Durrani [ adnan.durrani ] Yip Ng [ yip.ng ]
        Ken Fyten made changes -
        Field Original Value New Value
        Salesforce Case []
        Fix Version/s 1.8.2 [ 10190 ]
        Assignee Priority P3
        Assignee Adnan Durrani [ adnan.durrani ]
        Ken Fyten created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: