ICEfaces
  1. ICEfaces
  2. ICE-4865

Data Exporter: cannot determine the file type on IE upon saving/openning the file

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2
    • Fix Version/s: 1.8.2
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      ICEfaces trunk revision 19187
      IE6 and IE7

      Description

      When exporting data, a save dialog shows up. On IE browsers, the file type cannot be determined at that point of time. If saving file to a different type as defined, the file will only contain funky data.

      This affects component showcase sample application, too.
      1. screenshot-3.png
        254 kB
      2. screenshot-2.jpg
        219 kB
      3. screenshot-1.jpg
        256 kB
      4. fielType-IE6.jpg
        41 kB

        Activity

        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2
        Hide
        Joanne Bai added a comment -

        Fix confirmed on ICEfaces 1.8.2 build 1 (Tested on IE 6 and 7)

        Show
        Joanne Bai added a comment - Fix confirmed on ICEfaces 1.8.2 build 1 (Tested on IE 6 and 7)
        yip.ng made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        yip.ng added a comment - - edited

        Fixed by not writing the content disposition at all when file name is missing in registered resource. See screenshot-3.

        Show
        yip.ng added a comment - - edited Fixed by not writing the content disposition at all when file name is missing in registered resource. See screenshot-3.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #19263 Wed Sep 16 08:47:48 MDT 2009 yip.ng ICE-4865: Changed to not output content dispoisition header when there is no file name in the registered resource.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputresource/OutputResource.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/ResourceDispatcher.java
        yip.ng made changes -
        Attachment screenshot-3.png [ 11991 ]
        Ken Fyten made changes -
        Security Private [ 10001 ]
        Hide
        Ted Goddard added a comment -

        There is a MIME standard for the header that should help – but existing browsers are ignoring the standard. Was that the future fix?

        Show
        Ted Goddard added a comment - There is a MIME standard for the header that should help – but existing browsers are ignoring the standard. Was that the future fix?
        Hide
        yip.ng added a comment -

        No can do. See screenshot-1 and screenshot-2.

        withOptions() is called when the resource is served. By that time the FacesContext is already long gone. We need that to do browser detection. We need browser detection because content disposition file name is browser dependent. See ICE-4342 for more details.

        I remember we discussed all this in a meeting. And Ted (or Mark?) suggested something to fix this in the future.

        Show
        yip.ng added a comment - No can do. See screenshot-1 and screenshot-2. withOptions() is called when the resource is served. By that time the FacesContext is already long gone. We need that to do browser detection. We need browser detection because content disposition file name is browser dependent. See ICE-4342 for more details. I remember we discussed all this in a meeting. And Ted (or Mark?) suggested something to fix this in the future.
        yip.ng made changes -
        Attachment screenshot-1.jpg [ 11977 ]
        Attachment screenshot-2.jpg [ 11978 ]
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Adnan Durrani [ adnan.durrani ] Yip Ng [ yip.ng ]
        Adnan Durrani made changes -
        Attachment fielType-IE6.jpg [ 11976 ]
        Hide
        Joanne Bai added a comment -

        It works fine on 1.8.1 release. I reverted trunk back to revision 19076, and it worked fine too. But this issue existed when testing on revision 19114. So, it should be some revision in between 19076 and 19114 where it firstly occurred.

        Show
        Joanne Bai added a comment - It works fine on 1.8.1 release. I reverted trunk back to revision 19076, and it worked fine too. But this issue existed when testing on revision 19114. So, it should be some revision in between 19076 and 19114 where it firstly occurred.
        Ken Fyten made changes -
        Field Original Value New Value
        Salesforce Case []
        Fix Version/s 1.8.2 [ 10190 ]
        Assignee Priority P2
        Assignee Adnan Durrani [ adnan.durrani ]
        Joanne Bai created issue -

          People

          • Assignee:
            yip.ng
            Reporter:
            Joanne Bai
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: