Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.8
-
Component/s: ICE-Components
-
Labels:None
-
Environment:All
-
Affects:Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial
Description
It would be useful if users could override the label and/or image attribute-based mechanism for defining a panelTab label and instead optionally use an arbitrary facet to define the tab's label region. This would provide great flexibility for users wanting to use multiple components in the label section, or even to add a "close" button to the tab label itself.
Since clicking on the label region selects the tab for viewing special handling must be incorporated such that any input type components used in the label facet must *not* change the tab visibility when clicked, but instead will rely on their own click event handlers, which may set the tabs visibility if desired (or remove the tab completely as in the case of the "close" button).
Since clicking on the label region selects the tab for viewing special handling must be incorporated such that any input type components used in the label facet must *not* change the tab visibility when clicked, but instead will rely on their own click event handlers, which may set the tabs visibility if desired (or remove the tab completely as in the case of the "close" button).
Issue Links
- blocks
-
ICE-4624
Add demo to Component Showcase for new panelTab facet label feature
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Salesforce Case | [] | |
| Fix Version/s | 1.8.2 [ 10190 ] | |
| Affects | [Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial] | |
| Assignee Priority | P3 | |
| Assignee | Adnan Durrani [ adnan.durrani ] |
| Salesforce Case | [50070000008ovJg] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #18990 | Wed Jun 24 11:52:29 MDT 2009 | adnan.durrani | "label" facet added to the ice:panelTab component |
| Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css
MODIFY
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTab.java
MODIFY
/icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/custom/paneltab-renderer.xml
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime.css
|
| Status | In Progress [ 3 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Fix Version/s | 1.8.2-RC1 [ 10210 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Assignee Priority | P3 |
Was css modifications really necessary?
In my opinion css changes from revision 18990 and 19005 can be reverted because I see some problems
- without this changes label on tab works well
- syntax modification is not backward compatibile, tabs are not correctly displayed in IE6
instead
.icePnlTbOn .MidMid>a, .icePnlTbOn .MidMid>div {
can be old
.icePnlTbOn .MidMid a, .icePnlTbOn .MidMid div { - css syntax like
.icePnlTbOn .MidMid a, .icePnlTbOn .MidMid div {
increase twice size of tab area because div and a got the same big padding
<a class="icePnlTbLblLnk">
<div><table cellspacing="0" cellpadding="0"><tbody><tr><td>Tab title</td></tr></tbody></table></div></a>
Finnaly xp.css from revision 18990 was better than 19005.
Show
Krashan Brahmanjara
added a comment - Was css modifications really necessary?
In my opinion css changes from revision 18990 and 19005 can be reverted because I see some problems
without this changes label on tab works well
syntax modification is not backward compatibile, tabs are not correctly displayed in IE6
instead
.icePnlTbOn .MidMid>a, .icePnlTbOn .MidMid>div {
can be old
.icePnlTbOn .MidMid a, .icePnlTbOn .MidMid div {
css syntax like
.icePnlTbOn .MidMid a, .icePnlTbOn .MidMid div {
increase twice size of tab area because div and a got the same big padding
<a class="icePnlTbLblLnk">
<div><table cellspacing="0" cellpadding="0"><tbody><tr><td>Tab title</td></tr></tbody></table></div></a>
Finnaly xp.css from revision 18990 was better than 19005.
"label" facet added to the ice:panelTab.
<ice:panelTab >
<f:facet name="label">
<ice:panelGroup>
<ice:outputText value="Tab 1"/>
</ice:panelGroup>
</f:facet>
<ice:outputText value="Contents"/>
</ice:panelTab >
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTab.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\custom\paneltab-renderer.xml
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\rime\rime.css
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\xp\xp.css
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\xp\xp.css
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\rime\rime.css
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\custom\paneltab-renderer.xml
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTab.java
Completed: At revision: 18990