ICEfaces
  1. ICEfaces
  2. ICE-4261

REGRESSION: broken error handling mechanism for JSF 1.2

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8RC1, 1.8RC2
          • Fix Version/s: 1.8
          • Component/s: None
          • Labels:
            None
          • Environment:
            JSF1.2

            Description

            When verify the fix for ICE-3029, found error handling doesn't work anymore for JSF 1.2
            The last known working release is 1.7.2 SP1 and the issue present in both 1.8 RC1 and RC2.

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-4325 Bug in MainServlet, Jetty continuation does not work anymore, RetryRequest exception from Jetty get caught and not rethrown

              • Major - Major loss of function.
              • Closed

                Activity

                Descending order - Click to sort in ascending order
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #19039 Tue Jul 07 11:33:42 MDT 2009 ted.goddard ICE-4261: Modifying error handling when error does not contain a message.
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/push/servlet/PushResourceHandler.java
                Deryk Sinotte made changes -
                Link This issue blocks ICE-4325 [ ICE-4325 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #19004 Fri Jun 26 11:32:18 MDT 2009 deryk.sinotte ICE-4261: Modifying error handling when error does not contain a message.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/MainServlet.java
                Hide
                Permalink
                Greg Dick added a comment -

                Jetty uses a message-less RuntimeException to signal continuations: org.eclipse.jetty.server.RetryRequest This mechanism was broken by the above wrapping code. I've checked in a change that checks the classname and if it contains org.eclipse.jetty, it will throw the original exception unchanged.

                Show
                Greg Dick added a comment - Jetty uses a message-less RuntimeException to signal continuations: org.eclipse.jetty.server.RetryRequest This mechanism was broken by the above wrapping code. I've checked in a change that checks the classname and if it contains org.eclipse.jetty, it will throw the original exception unchanged.
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Deryk Sinotte [ deryk.sinotte ]
                Ken Fyten made changes -
                Assignee Priority P1
                Deryk Sinotte made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Deryk Sinotte added a comment -

                Checked in a change to MainServlet that wraps any RuntimeExceptions without a message in a new instance of RuntimeException that does have a message.

                Show
                Deryk Sinotte added a comment - Checked in a change to MainServlet that wraps any RuntimeExceptions without a message in a new instance of RuntimeException that does have a message.
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #18660 Wed Mar 25 17:39:55 MDT 2009 deryk.sinotte ICE-4261: wrapped RuntimeExceptions without messages in new instances of RuntimeExceptions with a message
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/MainServlet.java
                Ken Fyten made changes -
                Field Original Value New Value
                Salesforce Case []
                Fix Version/s 1.8 [ 10161 ]
                Assignee Priority P1
                Assignee Deryk Sinotte [ deryk.sinotte ]
                Sam Xiao created issue -

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Sam Xiao
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: