[#ICE-4200] Spring webflow 2.0.5 is incompatible with ICEFaces

ICEfaces

Spring webflow 2.0.5 is incompatible with ICEFaces

Created: 12/Mar/09 11:20 AM Updated: 10/Apr/09 11:27 AM

Component/s:

Framework

Affects Version/s:

1.8RC1

Fix Version/s:

1.8RC2, 1.8

Environment:

Spring Webflow 2.0.5 + ICEFaces 1.8

ICEsoft Forum Reference:

http://www.icefaces.org/JForum/posts/list/15/11246.page#47408

Description

« Hide

Code that works in Webflow 2.0.3 no longer works in 2.0.5

All

Comments

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Greg Dick added a comment - 17/Mar/09 05:31 PM

This turns out to be another problem with delegation support. There is a little section of code in the SpringFlowStateManager that decides if the view is restorable or not:

protected UIViewRoot restoreTreeStructure(FacesContext context, String viewId, String renderKitId) {
if (!JsfUtils.isFlowRequest()) {
return super.restoreTreeStructure(context, viewId, renderKitId);
}
RequestContext requestContext = RequestContextHolder.getRequestContext();
SerializedView view = (SerializedView) requestContext.getViewScope().get(SERIALIZED_VIEW_STATE);
if (view == null || !view.viewId.equals(viewId)) { <--------------------------- (1)
logger.debug("No matching view in view scope");
return null;
}

The view.viewIdWith ICEFaces + webflow 2.0.3, the viewId is pre-constructed to contain the path to the resource. An example viewId in the ICEFaces Booking example is "/WEB-INF/flows/enterSearchCriteria.xhtml"

In Spring 2.0.5, the path is not added as part of the Flow startup and instead the FlowViewHandler does a little bit of work to flesh out the path information using a resource loader. This code is not present in 2.0.3. The FlowViewHandler is likely loaded from the faces-config.xml as ours is, but it ls loaded before ours. Since our ViewHandler doesn't delegate the code to fill out the path in the viewId is never executed. Hence the flow is continuously restarted.

A workaround is to define a Spring FlowViewHandler in the application faces-config.xml file. This has certain disadvantages like causing a duplicate FlowViewHandler instance to be created.

<application>
        <view-handler>
            com.sun.facelets.FaceletViewHandler
        </view-handler>
        <view-handler>
            com.icesoft.faces.facelets.D2DFaceletViewHandler
        </view-handler>
        
        <view-handler>
            org.springframework.faces.webflow.FlowViewHandler
        </view-handler>

        <variable-resolver>org.springframework.web.jsf.DelegatingVariableResolver</variable-resolver>
    </application>

[ Show » ]

Greg Dick added a comment - 17/Mar/09 05:31 PM This turns out to be another problem with delegation support. There is a little section of code in the SpringFlowStateManager that decides if the view is restorable or not: protected UIViewRoot restoreTreeStructure(FacesContext context, String viewId, String renderKitId) { if (!JsfUtils.isFlowRequest()) { return super.restoreTreeStructure(context, viewId, renderKitId); } RequestContext requestContext = RequestContextHolder.getRequestContext(); SerializedView view = (SerializedView) requestContext.getViewScope().get(SERIALIZED_VIEW_STATE); if (view == null || !view.viewId.equals(viewId)) { <--------------------------- (1) logger.debug("No matching view in view scope"); return null; } The view.viewIdWith ICEFaces + webflow 2.0.3, the viewId is pre-constructed to contain the path to the resource. An example viewId in the ICEFaces Booking example is "/WEB-INF/flows/enterSearchCriteria.xhtml" In Spring 2.0.5, the path is not added as part of the Flow startup and instead the FlowViewHandler does a little bit of work to flesh out the path information using a resource loader. This code is not present in 2.0.3. The FlowViewHandler is likely loaded from the faces-config.xml as ours is, but it ls loaded before ours. Since our ViewHandler doesn't delegate the code to fill out the path in the viewId is never executed. Hence the flow is continuously restarted. A workaround is to define a Spring FlowViewHandler in the application faces-config.xml file. This has certain disadvantages like causing a duplicate FlowViewHandler instance to be created. <application> <view-handler> com.sun.facelets.FaceletViewHandler </view-handler> <view-handler> com.icesoft.faces.facelets.D2DFaceletViewHandler </view-handler>  <view-handler> org.springframework.faces.webflow.FlowViewHandler </view-handler> <variable-resolver>org.springframework.web.jsf.DelegatingVariableResolver</variable-resolver> </application>