ICEfaces
  1. ICEfaces
  2. ICE-3884

Partial submit change - restore "required" attributes in the pre RenderResponse phase instead of post RenderResponse.

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8DR#1
          • Fix Version/s: 1.8DR#2, 1.8
          • Component/s: Framework, ICE-Components
          • Labels:
            None
          • Environment:
            Any
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

            Description

            When partial submit is used and the "required" attributes are modified for other submitted components, the adjusted value of the attributed appears to persist too long. For reference on the failing behaviour, see ICE-2638 and ICE-2927 cases and their associated regression tests.

              Issue Links

              is duplicated by

              Bug - A problem which impairs or prevents the functions of the product. ICE-3883 remove PartialSubmitValueBinding objects before application server tries to serialize (Seam)

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #18058 Mon Dec 15 16:33:01 MST 2008 greg.dick ICE-3884 Restore required field flags before stateSavingn persists them
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/application/PartialSubmitPhaseListener.java
                Deryk Sinotte created issue -
                Deryk Sinotte made changes -
                Field Original Value New Value
                Salesforce Case []
                Assignee Priority P1
                Assignee Greg Dick [ greg.dick ]
                Deryk Sinotte made changes -
                Salesforce Case []
                Fix Version/s 1.8DR#2 [ 10142 ]
                Hide
                Permalink
                Ken Fyten added a comment -

                Suspect that these additional regression test failures are also related to this, should be confirmed with the fix:

                ICE-2367: Allow panelTabSet to change tabs without validation
                ICE-1883: Partial submit disables previous validation messages

                Show
                Ken Fyten added a comment - Suspect that these additional regression test failures are also related to this, should be confirmed with the fix: ICE-2367 : Allow panelTabSet to change tabs without validation ICE-1883 : Partial submit disables previous validation messages
                Ken Fyten made changes -
                Link This issue blocks ICE-3883 [ ICE-3883 ]
                Hide
                Permalink
                Greg Dick added a comment -

                The old behaviour of this code was to restore the required attribute of the component during the post RenderResponse phase. This meant that if other components in the form have the partial submit flag set to true, the the "required" attribute setting of components may be artificially turned off during rendering. This attribute was being restored, but only after the post renderResponse phase listener.

                This was a problem when state saving is turned on because state saving is capturing the state after rendering is done on the component, but before the end of the renderResponse phase. Due to the nature of our DOMResponseRenderer, it has to be done after rendering, but before the document is closed.

                The solution is to restore the correct state of the attributes in the pre render response phase listener.

                There could be some changes in behaviour in rendering but the underlying functionality of the 'required' attribute should not change.

                Show
                Greg Dick added a comment - The old behaviour of this code was to restore the required attribute of the component during the post RenderResponse phase. This meant that if other components in the form have the partial submit flag set to true, the the "required" attribute setting of components may be artificially turned off during rendering. This attribute was being restored, but only after the post renderResponse phase listener. This was a problem when state saving is turned on because state saving is capturing the state after rendering is done on the component, but before the end of the renderResponse phase. Due to the nature of our DOMResponseRenderer, it has to be done after rendering, but before the document is closed. The solution is to restore the correct state of the attributes in the pre render response phase listener. There could be some changes in behaviour in rendering but the underlying functionality of the 'required' attribute should not change.
                Greg Dick made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Summary Partial submit attributes are persisted too long when state saving is on. Partial submit change - restore "required" attributes in the pre render response phase
                Salesforce Case []
                Ken Fyten made changes -
                Summary Partial submit change - restore "required" attributes in the pre render response phase Partial submit change - restore "required" attributes in the pre RenderResponse phase instead of post RenderResponse.
                Salesforce Case []
                Ken Fyten made changes -
                Salesforce Case []
                Affects [Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration]
                Mark Collette made changes -
                Link This issue is duplicated by ICE-3883 [ ICE-3883 ]
                Mark Collette made changes -
                Link This issue blocks ICE-3883 [ ICE-3883 ]
                Ken Fyten made changes -
                Fix Version/s 1.8 [ 10161 ]
                Assignee Priority P1
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Greg Dick [ greg.dick ]

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Deryk Sinotte
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: