ICEfaces
  1. ICEfaces
  2. ICE-3482

MenuRenderer redundantly calling getValue()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.1
    • Fix Version/s: 1.7.2
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      MenuRenderer.renderOptions() calls renderOption() for every item. In renderOption() it calls isValueSelected(), which calls getCurrentSelectedValues(), when there are no submitted values. getCurrentSelectedValues() calls getValue(). So, for every option, we can call the same getValue(), which can get very expensive with Seam.

        Activity

        Mark Collette created issue -
        Mark Collette made changes -
        Field Original Value New Value
        Fix Version/s 1.7.2 [ 10130 ]
        Assignee Mark Collette [ mark.collette ]
        Ken Fyten made changes -
        Assignee Priority P2
        Mark Collette made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2
        Assignee Mark Collette [ mark.collette ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Mark Collette
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: