[#ICE-3372] Do not downgrade servlet spec in web.xml

ICEfaces

Do not downgrade servlet spec in web.xml

Created: 31/Jul/08 09:31 AM Updated: 10/Apr/09 11:31 AM

Component/s:

Tool Integrations

Affects Version/s:

1.7.1

Fix Version/s:

None

Environment:

n/a

ICEsoft Forum Reference:

http://www.icefaces.org/JForum/posts/list/0/9254.page

Description

« Hide

Our eclipse plugins will set the web.xml servlet spec to 2.4 when adding ICEfaces. If the user already has a web project set to 2.5, downgrading the spec to 2.4 can break 2.5-specific functionality, such as EJB injection. We should try not to reduce the servlet version. Have not tested with NetBeans, but we should also check that.

All

Comments

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Liming Wu added a comment - 31/Jul/08 10:33 AM

ICEfaces doesn't support JSF 1.2 as I know in 1.7.1 and that is why this restriction is set. This can be esaily removed if ICEfaces supports JSF 1.2

Downgrade is in MyEclipse. There is a dialog asking if user want to downgrade spec to 2.4/2.3. User can choose not to downgrade from 2.5 if they want to take the risk.

On Eclipse this restriction is applied. our tool doesn't really downgrade but won't let you add ICEfaces facet to 2.5 web project.

[ Permlink | « Hide ]

Philip Breau added a comment - 31/Jul/08 11:07 AM

afaik the jsf 1.1 compatibility mode is determined solely by the faces-config version, not the servlet version (http://jira.icefaces.org//browse/ICE-1474)

[ Permlink | « Hide ]

Ryan Daniels added a comment - 31/Jul/08 11:17 AM

If I am not mistaken, in MyEclipse, if you answer No to the downgrade, it will not set up the ICEFaces features in web.xml.

[ Permlink | « Hide ]

Philip Breau added a comment - 31/Jul/08 11:25 AM

actually, it's a bit misleading, but it still will carry out the addition and configuration of ICEfaces, but will leave the web.xml at 2.5 and the faces-config version at 1.2. ICEfaces will currently not run correctly if the faces-config version is at 1.2. I don't believe, however, that we need to downgrade the servlet version, just the faces-config version.

[ Permlink | « Hide ]

Liming Wu added a comment - 31/Jul/08 01:27 PM

jsf 1.1 compatibility mode is not (clearly) mentioned in JSF 1.2 spec. I wonder if compatibility mode is somewhat related to JSP 2.1/JSP 2.0 compatibility. If both servlet 2.5 / JSP 2.1 are compatible with servlet 2.4/JSP 2.0, we could possibly break the version alignment between servlet and faces. I will check the specs.

Do you have more info on compatibility mode? developer's guide needs to be changed as well if that is the case.

[ Permlink | « Hide ]

Philip Breau added a comment - 31/Jul/08 01:41 PM

there's no info on the compatibility mode, but servlet 2.5 is fully backwards compatible to 2.3, so I don't think there's anything to worry about (http://jcp.org/aboutJava/communityprocess/maintenance/jsr154/servlet-2.5_MR2.html).

[ Permlink | « Hide ]

Liming Wu added a comment - 08/Aug/08 09:33 PM

restriction removed in Eclipse 3.4 integration.

It needs to be removed from MyEclipse integration as well.

[ Permlink | « Hide ]

Liming Wu added a comment - 12/Sep/08 11:27 AM

done and checked in.

Eclipse 3.4 integration and MyEclipse 7.0 M2