Issue Details (XML | Word | Printable)

Key: ICE-1883
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Tyler Johnson
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
ICEfaces

Partial submit disables previous validation messages

Created: 17/Jul/07 12:45 PM   Updated: 14/Apr/08 03:32 PM
Component/s: Framework
Affects Version/s: 1.6
Fix Version/s: 1.7DR#3, 1.7

Environment: All

ICEfaces Forum Reference: https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=4171
Support Customer Ref. #s: 713, 724
Support Case References: https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=4171


 Description  « Hide
When using standard JSF validation on various required fields, the form is submitted and validation functions correctly. The required fields are flagged with ICEfaces messages and the form is not submitted. When partial submit is enabled, a user will enter data/click out of an input field and the form is partially submitted. The problem is that ICEfaces disables all required statuses in order to submit the page and when the partial submit returns, it does not retain the original validation messages for required inputs.

 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
User Philip.breau added a comment - 17/Jul/07 02:33 PM
This is a large usability more than a bug itself. We may want to have a default retainAfterPartialSubmit attribute on the ice:message and messages components, where they retain previous messages until a full submit.

Ted Goddard added a comment - 30/Jul/07 05:50 PM
A special message component variant is an interesting idea. Are we losing all validation error messages or just the "required" error messages?

Another option may be to create a custom validator that returns an error until it is cleared -- the validator would not test for an empty value until the component was "required", but once "required" would continue to test for an empty value.

Ted Goddard added a comment - 30/Jul/07 05:51 PM
Assigning to Philip to comment on which messages specifically are being lost (with input from Tyler from his observations).

User Philip.breau added a comment - 01/Aug/07 11:40 AM
This involves any validation message, whether arising from a conversion error, validation error, or missing required error. The proposed new behaviour would be quite simple. A new attribute, such as 'retainOnPartialSubmit' would cause the lifespan of a message to span partialSubmits and only be cleared on a full submit or a partialSubmit originating from the corresponding component of the message itself. This is the desired behaviour requested from both clients.

Adnan Durrani added a comment - 20/Nov/07 03:59 PM
Revision 15209

Adnan Durrani added a comment - 21/Nov/07 05:30 PM
revision 15220

Adnan Durrani added a comment - 22/Nov/07 05:54 PM
revision 15238

Adnan Durrani added a comment - 04/Dec/07 11:58 AM
revision: 15289

Ken Fyten added a comment - 05/Mar/08 11:17 AM
The implemented enhancement is to retain the display of error messages for any components that:
- Were in an invalid state prior to the partialSubmit
- Are not the component that is the subject of the partialSubmit

This supports the use-cases where user's are entering data in a partial-submit form, enter an invalid value in field 1, see the error msg., then move to field2 and enter a value there. Prior to this change the original error msg. from their invalid entry into field1 would disappear when field2 was partialSubmitted. Now error msgs for all invalid state components will continue to be displayed until they are in a valid state.